From 9f112af50abbcd059e3872ae63143c35bb8c0f7f Mon Sep 17 00:00:00 2001 From: Franco Meloni Date: Wed, 25 May 2022 07:00:29 -0700 Subject: [PATCH] Add comment to explain why production flag is used when Flipper is enabled (#33902) Summary: Follow up of https://github.com/facebook/react-native/pull/33882 ## Changelog [Internal] - Add comment to explain why production flag is used when Flipper is enabled Pull Request resolved: https://github.com/facebook/react-native/pull/33902 Reviewed By: cortinico, f-meloni Differential Revision: D36632238 Pulled By: cipolleschi fbshipit-source-id: a859006851d9f50a4ad0ae1141006e8dac7aee6e --- scripts/cocoapods/flipper.rb | 4 ++-- scripts/react_native_pods.rb | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/scripts/cocoapods/flipper.rb b/scripts/cocoapods/flipper.rb index 965a20060b0ac3..676a891e12cb05 100644 --- a/scripts/cocoapods/flipper.rb +++ b/scripts/cocoapods/flipper.rb @@ -103,10 +103,10 @@ def initialize(flipper_enabled, configurations, versions) end def self.enabled(configurations = ["Debug"], versions = {}) - return FlipperConfiguration.new(true, configurations, versions) + FlipperConfiguration.new(true, configurations, versions) end def self.disabled - return FlipperConfiguration.new(false, [], {}) + FlipperConfiguration.new(false, [], {}) end end diff --git a/scripts/react_native_pods.rb b/scripts/react_native_pods.rb index 0ea4898391c7fc..b6d33da6aed794 100644 --- a/scripts/react_native_pods.rb +++ b/scripts/react_native_pods.rb @@ -111,6 +111,10 @@ def use_react_native! (options={}) pod 'hermes-engine', :path => "#{prefix}/sdks/hermes/hermes-engine.podspec" end + # CocoaPods `configurations` option ensures that the target is copied only for the specified configurations, + # but those dependencies are still built. + # Flipper doesn't currently compile for release https://github.com/facebook/react-native/issues/33764 + # Setting the production flag to true when build for production make sure that we don't install Flipper in the app in the first place. if flipper_configuration.flipper_enabled && !production install_flipper_dependencies(prefix) use_flipper_pods(flipper_configuration.versions, :configurations => flipper_configuration.configurations)