Back out "Avoid accessing self.component on background thread"

Kim Svatos · facebook-github-bot · commit 5d8fcde6320c · 2020-12-03T19:09:50.000-08:00
Summary: Changelog: [Internal] backout change dispatching main queue before using it

Reviewed By: shergin

Differential Revision: D25319046

fbshipit-source-id: 4f8952e577cfd9033fb2c2248b9b056a0d468b5d
diff --git a/Libraries/SurfaceHostingComponent/RCTSurfaceHostingComponentController.mm b/Libraries/SurfaceHostingComponent/RCTSurfaceHostingComponentController.mm
@@ -130,18 +130,12 @@ - (void)unmountSurfaceView
 
 - (void)surface:(RCTSurface *)surface didChangeIntrinsicSize:(CGSize)intrinsicSize
 {
-  __weak const auto weakSelf = self;
-  dispatch_async(dispatch_get_main_queue(), ^{
-    [weakSelf setIntrinsicSize:intrinsicSize];
-  });
+  [self setIntrinsicSize:intrinsicSize];
 }
 
 - (void)surface:(RCTSurface *)surface didChangeStage:(RCTSurfaceStage)stage
 {
-  __weak const auto weakSelf = self;
-  dispatch_async(dispatch_get_main_queue(), ^{
-    [weakSelf setStage:stage];
-  });
+  [self setStage:stage];
 }
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -130,18 +130,12 @@ - (void)unmountSurfaceView`
`130`	`130`
`131`	`131`	`- (void)surface:(RCTSurface *)surface didChangeIntrinsicSize:(CGSize)intrinsicSize`
`132`	`132`	`{`
`133`		`- __weak const auto weakSelf = self;`
`134`		`- dispatch_async(dispatch_get_main_queue(), ^{`
`135`		`- [weakSelf setIntrinsicSize:intrinsicSize];`
`136`		`- });`
	`133`	`+ [self setIntrinsicSize:intrinsicSize];`
`137`	`134`	`}`
`138`	`135`
`139`	`136`	`- (void)surface:(RCTSurface *)surface didChangeStage:(RCTSurfaceStage)stage`
`140`	`137`	`{`
`141`		`- __weak const auto weakSelf = self;`
`142`		`- dispatch_async(dispatch_get_main_queue(), ^{`
`143`		`- [weakSelf setStage:stage];`
`144`		`- });`
	`138`	`+ [self setStage:stage];`
`145`	`139`	`}`
`146`	`140`
`147`	`141`	`@end`