Skip to content

Commit 4216cde

Browse files
hramosfacebook-github-bot
authored andcommittedDec 21, 2017
Do not use Node 8.x specific Stream.final
Summary: grabbou: "This has been recently added to Node 8.x. Since it makes our tests to fail, I decided to do a workaround that works for all the versions." Originally patched in `0.52-stable` by grabbou Fixes Node 6 JavaScript tests. Closes #17298 Differential Revision: D6616521 Pulled By: hramos fbshipit-source-id: 7256450d824a60a14006af7a68191222b3a5041a
1 parent a0ff8c7 commit 4216cde

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed
 

‎local-cli/__mocks__/fs.js

-3
Original file line numberDiff line numberDiff line change
@@ -347,9 +347,6 @@ fs.createWriteStream.mockImplementation(filePath => {
347347
const writeStream = new stream.Writable({
348348
write(chunk, encoding, callback) {
349349
this.__chunks.push(chunk);
350-
callback();
351-
},
352-
final(callback) {
353350
node[path.basename(filePath)] = this.__chunks.join('');
354351
callback();
355352
},

0 commit comments

Comments
 (0)
Please sign in to comment.