tvOS: TV nav event emitter should check for bridge

douglowder · facebook-github-bot · commit 3a3d884df253 · 2018-02-16T14:36:56.000-08:00
Summary: When running with the packager in the tvOS simulator, reloading from the packager hits an assert in `RCTEventEmitter`, causing a crash. The solution is for `RCTTVNavigationEventEmitter` to check for the existence of the bridge before attempting to send an event. Manual testing. [IOS] [BUGFIX] [RCTTVNavigationEventEmitter.m] - Fix crash when reloading in tvOS Closes #17797 Differential Revision: D7014975 Pulled By: hramos fbshipit-source-id: 0bf766e87267ca8592ff0cc0b3cb4621a8e8f9b5
diff --git a/React/Modules/RCTTVNavigationEventEmitter.m b/React/Modules/RCTTVNavigationEventEmitter.m
@@ -46,7 +46,9 @@ - (void)dealloc
 
 - (void)handleTVNavigationEventNotification:(NSNotification *)notif
 {
-  [self sendEventWithName:TVNavigationEventName body:notif.object];
+  if (self.bridge) {
+    [self sendEventWithName:TVNavigationEventName body:notif.object];
+  }
 }
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,9 @@ - (void)dealloc`
`46`	`46`
`47`	`47`	`- (void)handleTVNavigationEventNotification:(NSNotification *)notif`
`48`	`48`	`{`
`49`		`- [self sendEventWithName:TVNavigationEventName body:notif.object];`
	`49`	`+ if (self.bridge) {`
	`50`	`+ [self sendEventWithName:TVNavigationEventName body:notif.object];`
	`51`	`+ }`
`50`	`52`	`}`
`51`	`53`
`52`	`54`	`@end`