Skip to content

Commit 201f2f1

Browse files
mcolottofacebook-github-bot
authored andcommittedSep 25, 2018
ReactScrollView should account for overflow: scroll
Summary: Support for `overflow: visible` was recently added to Android ScrollView. However, it didn't account for `overflow: scroll` and changed the behavior, causing content to render when before it would be clipped. Reviewed By: achen1 Differential Revision: D10036807 fbshipit-source-id: e44a79b18eecbc7d64621f7cf5d800a00a121b13
1 parent 1323acd commit 201f2f1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

‎ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollView.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ protected void onDraw(Canvas canvas) {
195195
switch (mOverflow) {
196196
case ViewProps.VISIBLE:
197197
break;
198-
case ViewProps.HIDDEN:
198+
default:
199199
canvas.clipRect(mRect);
200200
break;
201201
}

‎ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ public void draw(Canvas canvas) {
384384
switch (mOverflow) {
385385
case ViewProps.VISIBLE:
386386
break;
387-
case ViewProps.HIDDEN:
387+
default:
388388
canvas.clipRect(mRect);
389389
break;
390390
}

0 commit comments

Comments
 (0)
Please sign in to comment.