Skip to content

Commit 19a9c5e

Browse files
sherginfacebook-github-bot
authored andcommittedDec 20, 2017
The Great File Renaming in RCTText
Summary: The previous file/class name convention seemed cool... but now it drives me BANANAS! It makes all this code really hard to maintain. So, evething were renamed following common modern RN convention. Reviewed By: mmmulani Differential Revision: D6605090 fbshipit-source-id: 88ca13d793a5d2adaac2b7922ec6bd4654aacec5
1 parent 5c8481e commit 19a9c5e

40 files changed

+385
-251
lines changed
 

‎Libraries/Components/ScrollResponder.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ function isTagInstanceOfTextInput(tag) {
126126
var instance = getInstanceFromNode(tag);
127127
return instance && instance.viewConfig && (
128128
instance.viewConfig.uiViewClassName === 'AndroidTextInput' ||
129-
instance.viewConfig.uiViewClassName === 'RCTTextView' ||
130-
instance.viewConfig.uiViewClassName === 'RCTTextField'
129+
instance.viewConfig.uiViewClassName === 'RCTMultilineTextInputView' ||
130+
instance.viewConfig.uiViewClassName === 'RCTSinglelineTextInputView'
131131
);
132132
}
133133

‎Libraries/Components/TextInput/TextInput.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ const onlyMultiline = {
5050
if (Platform.OS === 'android') {
5151
var AndroidTextInput = requireNativeComponent('AndroidTextInput', null);
5252
} else if (Platform.OS === 'ios') {
53-
var RCTTextView = requireNativeComponent('RCTTextView', null);
54-
var RCTTextField = requireNativeComponent('RCTTextField', null);
53+
var RCTMultilineTextInputView = requireNativeComponent('RCTMultilineTextInputView', null);
54+
var RCTSinglelineTextInputView = requireNativeComponent('RCTSinglelineTextInputView', null);
5555
}
5656

5757
type Event = Object;
@@ -707,7 +707,7 @@ const TextInput = createReactClass({
707707
}
708708
}
709709
textContainer =
710-
<RCTTextField
710+
<RCTSinglelineTextInputView
711711
ref={this._setNativeRef}
712712
{...props}
713713
onFocus={this._onFocus}
@@ -733,7 +733,7 @@ const TextInput = createReactClass({
733733
}
734734
props.style.unshift(styles.multilineInput);
735735
textContainer =
736-
<RCTTextView
736+
<RCTMultilineTextInputView
737737
ref={this._setNativeRef}
738738
{...props}
739739
children={children}
@@ -926,8 +926,8 @@ const TextInput = createReactClass({
926926

927927
var styles = StyleSheet.create({
928928
multilineInput: {
929-
// This default top inset makes RCTTextView seem as close as possible
930-
// to single-line RCTTextField defaults, using the system defaults
929+
// This default top inset makes RCTMultilineTextInputView seem as close as possible
930+
// to single-line RCTSinglelineTextInputView defaults, using the system defaults
931931
// of font size 17 and a height of 31 points.
932932
paddingTop: 5,
933933
},

‎Libraries/Text/RCTShadowRawText.h ‎Libraries/Text/RCTRawTextShadowView.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
#import <React/RCTShadowView.h>
1111

12-
@interface RCTShadowRawText : RCTShadowView
12+
@interface RCTRawTextShadowView : RCTShadowView
1313

1414
@property (nonatomic, copy) NSString *text;
1515

‎Libraries/Text/RCTShadowRawText.m ‎Libraries/Text/RCTRawTextShadowView.m

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTShadowRawText.h"
10+
#import "RCTRawTextShadowView.h"
1111

1212
#import <React/RCTUIManager.h>
1313

14-
@implementation RCTShadowRawText
14+
@implementation RCTRawTextShadowView
1515

1616
- (instancetype)init
1717
{

‎Libraries/Text/RCTRawTextManager.h ‎Libraries/Text/RCTRawTextViewManager.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99

1010
#import <React/RCTViewManager.h>
1111

12-
@interface RCTRawTextManager : RCTViewManager
12+
@interface RCTRawTextViewManager : RCTViewManager
1313

1414
@end

‎Libraries/Text/RCTRawTextManager.m ‎Libraries/Text/RCTRawTextViewManager.m

+5-5
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,17 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTRawTextManager.h"
10+
#import "RCTRawTextViewManager.h"
1111

12-
#import "RCTShadowRawText.h"
12+
#import "RCTRawTextShadowView.h"
1313

14-
@implementation RCTRawTextManager
14+
@implementation RCTRawTextViewManager
1515

16-
RCT_EXPORT_MODULE()
16+
RCT_EXPORT_MODULE(RCTRawText)
1717

1818
- (RCTShadowView *)shadowView
1919
{
20-
return [RCTShadowRawText new];
20+
return [RCTRawTextShadowView new];
2121
}
2222

2323
RCT_EXPORT_SHADOW_PROPERTY(text, NSString)

‎Libraries/Text/RCTText.xcodeproj/project.pbxproj

+248-138
Large diffs are not rendered by default.

‎Libraries/Text/RCTShadowText.h ‎Libraries/Text/Text/RCTTextShadowView.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ typedef NS_ENUM(NSInteger, RCTSizeComparison)
2121
extern NSString *const RCTIsHighlightedAttributeName;
2222
extern NSString *const RCTReactTagAttributeName;
2323

24-
@interface RCTShadowText : RCTShadowView
24+
@interface RCTTextShadowView : RCTShadowView
2525

2626
@property (nonatomic, strong) UIColor *color;
2727
@property (nonatomic, strong) UIColor *backgroundColor;

‎Libraries/Text/RCTShadowText.m ‎Libraries/Text/Text/RCTTextShadowView.m

+21-21
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTShadowText.h"
10+
#import "RCTTextShadowView.h"
1111

1212
#import <React/RCTAccessibilityManager.h>
1313
#import <React/RCTBridge.h>
@@ -18,9 +18,9 @@
1818
#import <React/RCTUIManager.h>
1919
#import <React/RCTUtils.h>
2020

21-
#import "RCTShadowRawText.h"
22-
#import "RCTText.h"
21+
#import "RCTRawTextShadowView.h"
2322
#import "RCTTextView.h"
23+
#import "RCTMultilineTextInputView.h"
2424

2525
NSString *const RCTIsHighlightedAttributeName = @"IsHighlightedAttributeName";
2626
NSString *const RCTReactTagAttributeName = @"ReactTagAttributeName";
@@ -31,7 +31,7 @@
3131
static CGFloat const kAutoSizeHeightErrorMargin = 0.025f;
3232
static CGFloat const kAutoSizeGranularity = 0.001f;
3333

34-
@implementation RCTShadowText
34+
@implementation RCTTextShadowView
3535
{
3636
NSTextStorage *_cachedTextStorage;
3737
CGFloat _cachedTextStorageWidth;
@@ -43,7 +43,7 @@ @implementation RCTShadowText
4343

4444
static YGSize RCTMeasure(YGNodeRef node, float width, YGMeasureMode widthMode, float height, YGMeasureMode heightMode)
4545
{
46-
RCTShadowText *shadowText = (__bridge RCTShadowText *)YGNodeGetContext(node);
46+
RCTTextShadowView *shadowText = (__bridge RCTTextShadowView *)YGNodeGetContext(node);
4747
NSTextStorage *textStorage = [shadowText buildTextStorageForWidth:width widthMode:widthMode];
4848
[shadowText calculateTextFrame:textStorage];
4949
NSLayoutManager *layoutManager = textStorage.layoutManagers.firstObject;
@@ -109,7 +109,7 @@ - (void)contentSizeMultiplierDidChange:(NSNotification *)note
109109
- (NSDictionary<NSString *, id> *)processUpdatedProperties:(NSMutableSet<RCTApplierBlock> *)applierBlocks
110110
parentProperties:(NSDictionary<NSString *, id> *)parentProperties
111111
{
112-
if ([[self reactSuperview] isKindOfClass:[RCTShadowText class]]) {
112+
if ([[self reactSuperview] isKindOfClass:[RCTTextShadowView class]]) {
113113
return parentProperties;
114114
}
115115

@@ -122,22 +122,22 @@ - (void)contentSizeMultiplierDidChange:(NSNotification *)note
122122
CGRect textFrame = [self calculateTextFrame:textStorage];
123123
BOOL selectable = _selectable;
124124
[applierBlocks addObject:^(NSDictionary<NSNumber *, UIView *> *viewRegistry) {
125-
RCTText *view = (RCTText *)viewRegistry[self.reactTag];
125+
RCTTextView *view = (RCTTextView *)viewRegistry[self.reactTag];
126126
view.textFrame = textFrame;
127127
view.textStorage = textStorage;
128128
view.selectable = selectable;
129129

130130
/**
131131
* NOTE: this logic is included to support rich text editing inside multiline
132132
* `<TextInput>` controls. It is required in order to ensure that the
133-
* textStorage (aka attributed string) is copied over from the RCTShadowText
134-
* to the RCTText view in time to be used to update the editable text content.
135-
* TODO: we should establish a delegate relationship betweeen RCTTextView
136-
* and its contaned RCTText element when they get inserted and get rid of this
133+
* textStorage (aka attributed string) is copied over from the RCTTextShadowView
134+
* to the RCTTextView view in time to be used to update the editable text content.
135+
* TODO: we should establish a delegate relationship betweeen RCTMultilineTextInputView
136+
* and its contaned RCTTextView element when they get inserted and get rid of this
137137
*/
138138
UIView *parentView = viewRegistry[parentTag];
139139
if ([parentView respondsToSelector:@selector(performTextUpdate)]) {
140-
[(RCTTextView *)parentView performTextUpdate];
140+
[(RCTMultilineTextInputView *)parentView performTextUpdate];
141141
}
142142
}];
143143

@@ -308,8 +308,8 @@ - (NSAttributedString *)_attributedStringWithFontFamily:(NSString *)fontFamily
308308
CGFloat heightOfTallestSubview = 0.0;
309309
NSMutableAttributedString *attributedString = [NSMutableAttributedString new];
310310
for (RCTShadowView *child in [self reactSubviews]) {
311-
if ([child isKindOfClass:[RCTShadowText class]]) {
312-
RCTShadowText *shadowText = (RCTShadowText *)child;
311+
if ([child isKindOfClass:[RCTTextShadowView class]]) {
312+
RCTTextShadowView *shadowText = (RCTTextShadowView *)child;
313313
[attributedString appendAttributedString:
314314
[shadowText _attributedStringWithFontFamily:fontFamily
315315
fontSize:fontSize
@@ -321,8 +321,8 @@ - (NSAttributedString *)_attributedStringWithFontFamily:(NSString *)fontFamily
321321
backgroundColor:shadowText.backgroundColor ?: backgroundColor
322322
opacity:opacity * shadowText.opacity]];
323323
[child setTextComputed];
324-
} else if ([child isKindOfClass:[RCTShadowRawText class]]) {
325-
RCTShadowRawText *shadowRawText = (RCTShadowRawText *)child;
324+
} else if ([child isKindOfClass:[RCTRawTextShadowView class]]) {
325+
RCTRawTextShadowView *shadowRawText = (RCTRawTextShadowView *)child;
326326
[attributedString appendAttributedString:[[NSAttributedString alloc] initWithString:shadowRawText.text ?: @""]];
327327
[child setTextComputed];
328328
} else {
@@ -340,7 +340,7 @@ - (NSAttributedString *)_attributedStringWithFontFamily:(NSString *)fontFamily
340340
if (height > heightOfTallestSubview) {
341341
heightOfTallestSubview = height;
342342
}
343-
// Don't call setTextComputed on this child. RCTTextManager takes care of
343+
// Don't call setTextComputed on this child. RCTTextViewManager takes care of
344344
// processing inline UIViews.
345345
}
346346
}
@@ -653,8 +653,8 @@ - (void)setAllowFontScaling:(BOOL)allowFontScaling
653653
{
654654
_allowFontScaling = allowFontScaling;
655655
for (RCTShadowView *child in [self reactSubviews]) {
656-
if ([child isKindOfClass:[RCTShadowText class]]) {
657-
((RCTShadowText *)child).allowFontScaling = allowFontScaling;
656+
if ([child isKindOfClass:[RCTTextShadowView class]]) {
657+
((RCTTextShadowView *)child).allowFontScaling = allowFontScaling;
658658
}
659659
}
660660
[self dirtyText];
@@ -668,8 +668,8 @@ - (void)setFontSizeMultiplier:(CGFloat)fontSizeMultiplier
668668
_fontSizeMultiplier = 1.0;
669669
}
670670
for (RCTShadowView *child in [self reactSubviews]) {
671-
if ([child isKindOfClass:[RCTShadowText class]]) {
672-
((RCTShadowText *)child).fontSizeMultiplier = fontSizeMultiplier;
671+
if ([child isKindOfClass:[RCTTextShadowView class]]) {
672+
((RCTTextShadowView *)child).fontSizeMultiplier = fontSizeMultiplier;
673673
}
674674
}
675675
[self dirtyText];

‎Libraries/Text/RCTText.h ‎Libraries/Text/Text/RCTTextView.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
#import <UIKit/UIKit.h>
1111

12-
@interface RCTText : UIView
12+
@interface RCTTextView : UIView
1313

1414
@property (nonatomic, assign) UIEdgeInsets contentInset;
1515
@property (nonatomic, strong) NSTextStorage *textStorage;

‎Libraries/Text/RCTText.m ‎Libraries/Text/Text/RCTTextView.m

+6-6
Original file line numberDiff line numberDiff line change
@@ -7,27 +7,27 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTText.h"
10+
#import "RCTTextView.h"
1111

1212
#import <MobileCoreServices/UTCoreTypes.h>
1313

1414
#import <React/RCTUtils.h>
1515
#import <React/UIView+React.h>
1616

17-
#import "RCTShadowText.h"
17+
#import "RCTTextShadowView.h"
1818

19-
static void collectNonTextDescendants(RCTText *view, NSMutableArray *nonTextDescendants)
19+
static void collectNonTextDescendants(RCTTextView *view, NSMutableArray *nonTextDescendants)
2020
{
2121
for (UIView *child in view.reactSubviews) {
22-
if ([child isKindOfClass:[RCTText class]]) {
23-
collectNonTextDescendants((RCTText *)child, nonTextDescendants);
22+
if ([child isKindOfClass:[RCTTextView class]]) {
23+
collectNonTextDescendants((RCTTextView *)child, nonTextDescendants);
2424
} else if (!CGRectEqualToRect(child.frame, CGRectZero)) {
2525
[nonTextDescendants addObject:child];
2626
}
2727
}
2828
}
2929

30-
@implementation RCTText
30+
@implementation RCTTextView
3131
{
3232
NSTextStorage *_textStorage;
3333
CAShapeLayer *_highlightLayer;
File renamed without changes.

‎Libraries/Text/RCTTextManager.m ‎Libraries/Text/Text/RCTTextViewManager.m

+22-22
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTTextManager.h"
10+
#import "RCTTextViewManager.h"
1111

1212
#import <React/RCTAccessibilityManager.h>
1313
#import <React/RCTAssert.h>
@@ -17,42 +17,42 @@
1717
#import <React/UIView+React.h>
1818
#import <yoga/Yoga.h>
1919

20-
#import "RCTShadowRawText.h"
21-
#import "RCTShadowText.h"
22-
#import "RCTText.h"
20+
#import "RCTRawTextShadowView.h"
21+
#import "RCTTextShadowView.h"
2322
#import "RCTTextView.h"
23+
#import "RCTMultilineTextInputView.h"
2424

25-
static void collectDirtyNonTextDescendants(RCTShadowText *shadowView, NSMutableArray *nonTextDescendants) {
25+
static void collectDirtyNonTextDescendants(RCTTextShadowView *shadowView, NSMutableArray *nonTextDescendants) {
2626
for (RCTShadowView *child in shadowView.reactSubviews) {
27-
if ([child isKindOfClass:[RCTShadowText class]]) {
28-
collectDirtyNonTextDescendants((RCTShadowText *)child, nonTextDescendants);
29-
} else if ([child isKindOfClass:[RCTShadowRawText class]]) {
27+
if ([child isKindOfClass:[RCTTextShadowView class]]) {
28+
collectDirtyNonTextDescendants((RCTTextShadowView *)child, nonTextDescendants);
29+
} else if ([child isKindOfClass:[RCTRawTextShadowView class]]) {
3030
// no-op
3131
} else if ([child isTextDirty]) {
3232
[nonTextDescendants addObject:child];
3333
}
3434
}
3535
}
3636

37-
@interface RCTShadowText (Private)
37+
@interface RCTTextShadowView (Private)
3838

3939
- (NSTextStorage *)buildTextStorageForWidth:(CGFloat)width widthMode:(YGMeasureMode)widthMode;
4040

4141
@end
4242

4343

44-
@implementation RCTTextManager
44+
@implementation RCTTextViewManager
4545

46-
RCT_EXPORT_MODULE()
46+
RCT_EXPORT_MODULE(RCTText)
4747

4848
- (UIView *)view
4949
{
50-
return [RCTText new];
50+
return [RCTTextView new];
5151
}
5252

5353
- (RCTShadowView *)shadowView
5454
{
55-
return [RCTShadowText new];
55+
return [RCTTextShadowView new];
5656
}
5757

5858
#pragma mark - Shadow properties
@@ -101,13 +101,13 @@ - (RCTViewManagerUIBlock)uiBlockToAmendWithShadowViewRegistry:(NSDictionary<NSNu
101101
RCTShadowView *shadowView = queue[i];
102102
RCTAssert([shadowView isTextDirty], @"Don't process any nodes that don't have dirty text");
103103

104-
if ([shadowView isKindOfClass:[RCTShadowText class]]) {
105-
((RCTShadowText *)shadowView).fontSizeMultiplier = self.bridge.accessibilityManager.multiplier;
106-
[(RCTShadowText *)shadowView recomputeText];
107-
collectDirtyNonTextDescendants((RCTShadowText *)shadowView, queue);
108-
} else if ([shadowView isKindOfClass:[RCTShadowRawText class]]) {
104+
if ([shadowView isKindOfClass:[RCTTextShadowView class]]) {
105+
((RCTTextShadowView *)shadowView).fontSizeMultiplier = self.bridge.accessibilityManager.multiplier;
106+
[(RCTTextShadowView *)shadowView recomputeText];
107+
collectDirtyNonTextDescendants((RCTTextShadowView *)shadowView, queue);
108+
} else if ([shadowView isKindOfClass:[RCTRawTextShadowView class]]) {
109109
RCTLogError(@"Raw text cannot be used outside of a <Text> tag. Not rendering string: '%@'",
110-
[(RCTShadowRawText *)shadowView text]);
110+
[(RCTRawTextShadowView *)shadowView text]);
111111
} else {
112112
for (RCTShadowView *child in [shadowView reactSubviews]) {
113113
if ([child isTextDirty]) {
@@ -123,13 +123,13 @@ - (RCTViewManagerUIBlock)uiBlockToAmendWithShadowViewRegistry:(NSDictionary<NSNu
123123
return nil;
124124
}
125125

126-
- (RCTViewManagerUIBlock)uiBlockToAmendWithShadowView:(RCTShadowText *)shadowView
126+
- (RCTViewManagerUIBlock)uiBlockToAmendWithShadowView:(RCTTextShadowView *)shadowView
127127
{
128128
NSNumber *reactTag = shadowView.reactTag;
129129
UIEdgeInsets padding = shadowView.paddingAsInsets;
130130

131-
return ^(RCTUIManager *uiManager, NSDictionary<NSNumber *, RCTText *> *viewRegistry) {
132-
RCTText *text = viewRegistry[reactTag];
131+
return ^(RCTUIManager *uiManager, NSDictionary<NSNumber *, RCTTextView *> *viewRegistry) {
132+
RCTTextView *text = viewRegistry[reactTag];
133133
text.contentInset = padding;
134134
};
135135
}

‎Libraries/Text/RCTShadowTextView.h ‎Libraries/Text/TextInput/Multiline/RCTMultilineTextInputShadowView.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99

1010
#import <React/RCTShadowView.h>
1111

12-
@interface RCTShadowTextView : RCTShadowView
12+
@interface RCTMultilineTextInputShadowView : RCTShadowView
1313

1414
@end

‎Libraries/Text/RCTShadowTextView.m ‎Libraries/Text/TextInput/Multiline/RCTMultilineTextInputShadowView.m

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTShadowTextView.h"
10+
#import "RCTMultilineTextInputShadowView.h"
1111

12-
@implementation RCTShadowTextView
12+
@implementation RCTMultilineTextInputShadowView
1313

1414
- (BOOL)isYogaLeafNode
1515
{

‎Libraries/Text/RCTTextView.h ‎Libraries/Text/TextInput/Multiline/RCTMultilineTextInputView.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
#import <React/RCTView.h>
1313
#import <React/UIView+React.h>
1414

15-
#import "RCTTextInput.h"
15+
#import "RCTBaseTextInputView.h"
1616

1717
@class RCTBridge;
1818

19-
@interface RCTTextView : RCTTextInput
19+
@interface RCTMultilineTextInputView : RCTBaseTextInputView
2020

2121
@property (nonatomic, assign) UITextAutocorrectionType autocorrectionType;
2222
@property (nonatomic, assign) UITextSpellCheckingType spellCheckingType;

‎Libraries/Text/RCTTextView.m ‎Libraries/Text/TextInput/Multiline/RCTMultilineTextInputView.m

+8-8
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTTextView.h"
10+
#import "RCTMultilineTextInputView.h"
1111

1212
#import <React/RCTConvert.h>
1313
#import <React/RCTEventDispatcher.h>
@@ -16,19 +16,19 @@
1616
#import <React/RCTUtils.h>
1717
#import <React/UIView+React.h>
1818

19-
#import "RCTShadowText.h"
20-
#import "RCTText.h"
19+
#import "RCTTextShadowView.h"
20+
#import "RCTTextView.h"
2121
#import "RCTTextSelection.h"
2222
#import "RCTUITextView.h"
2323

24-
@interface RCTTextView () <RCTBackedTextInputDelegate>
24+
@interface RCTMultilineTextInputView () <RCTBackedTextInputDelegate>
2525

2626
@end
2727

28-
@implementation RCTTextView
28+
@implementation RCTMultilineTextInputView
2929
{
3030
RCTUITextView *_backedTextInput;
31-
RCTText *_richTextView;
31+
RCTTextView *_richTextView;
3232
NSAttributedString *_pendingAttributedText;
3333

3434
NSString *_predictedText;
@@ -77,11 +77,11 @@ - (void)insertReactSubview:(UIView *)subview atIndex:(NSInteger)index
7777
{
7878
[super insertReactSubview:subview atIndex:index];
7979

80-
if ([subview isKindOfClass:[RCTText class]]) {
80+
if ([subview isKindOfClass:[RCTTextView class]]) {
8181
if (_richTextView) {
8282
RCTLogError(@"Tried to insert a second <Text> into <TextInput> - there can only be one.");
8383
}
84-
_richTextView = (RCTText *)subview;
84+
_richTextView = (RCTTextView *)subview;
8585

8686
// If this <TextInput> is in rich text editing mode, and the child <Text> node providing rich text
8787
// styling has a backgroundColor, then the attributedText produced by the child <Text> node will have an

‎Libraries/Text/RCTTextFieldManager.h ‎Libraries/Text/TextInput/Multiline/RCTMultilineTextInputViewManager.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99

1010
#import <React/RCTViewManager.h>
1111

12-
@interface RCTTextFieldManager : RCTViewManager
12+
@interface RCTMultilineTextInputViewManager : RCTViewManager
1313

1414
@end

‎Libraries/Text/RCTTextViewManager.m ‎Libraries/Text/TextInput/Multiline/RCTMultilineTextInputViewManager.m

+8-8
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTTextViewManager.h"
10+
#import "RCTMultilineTextInputViewManager.h"
1111

1212
#import <React/RCTBridge.h>
1313
#import <React/RCTConvert.h>
@@ -16,21 +16,21 @@
1616
#import <React/RCTShadowView.h>
1717

1818
#import "RCTConvert+Text.h"
19-
#import "RCTShadowTextView.h"
20-
#import "RCTTextView.h"
19+
#import "RCTMultilineTextInputShadowView.h"
20+
#import "RCTMultilineTextInputView.h"
2121

22-
@implementation RCTTextViewManager
22+
@implementation RCTMultilineTextInputViewManager
2323

2424
RCT_EXPORT_MODULE()
2525

2626
- (RCTShadowView *)shadowView
2727
{
28-
return [RCTShadowTextView new];
28+
return [RCTMultilineTextInputShadowView new];
2929
}
3030

3131
- (UIView *)view
3232
{
33-
return [[RCTTextView alloc] initWithBridge:self.bridge];
33+
return [[RCTMultilineTextInputView alloc] initWithBridge:self.bridge];
3434
}
3535

3636
#pragma mark - Unified <TextInput> properties
@@ -80,8 +80,8 @@ - (RCTViewManagerUIBlock)uiBlockToAmendWithShadowView:(RCTShadowView *)shadowVie
8080
NSNumber *reactTag = shadowView.reactTag;
8181
UIEdgeInsets borderAsInsets = shadowView.borderAsInsets;
8282
UIEdgeInsets paddingAsInsets = shadowView.paddingAsInsets;
83-
return ^(RCTUIManager *uiManager, NSDictionary<NSNumber *, RCTTextInput *> *viewRegistry) {
84-
RCTTextInput *view = viewRegistry[reactTag];
83+
return ^(RCTUIManager *uiManager, NSDictionary<NSNumber *, RCTBaseTextInputView *> *viewRegistry) {
84+
RCTBaseTextInputView *view = viewRegistry[reactTag];
8585
view.reactBorderInsets = borderAsInsets;
8686
view.reactPaddingInsets = paddingAsInsets;
8787
};

‎Libraries/Text/RCTTextInput.h ‎Libraries/Text/TextInput/RCTBaseTextInputView.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
@class RCTEventDispatcher;
2020
@class RCTTextSelection;
2121

22-
@interface RCTTextInput : RCTView <RCTFontAttributesDelegate> {
22+
@interface RCTBaseTextInputView : RCTView <RCTFontAttributesDelegate> {
2323
@protected
2424
__weak RCTBridge *_bridge;
2525
RCTEventDispatcher *_eventDispatcher;

‎Libraries/Text/RCTTextInput.m ‎Libraries/Text/TextInput/RCTBaseTextInputView.m

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTTextInput.h"
10+
#import "RCTBaseTextInputView.h"
1111

1212
#import <React/RCTAccessibilityManager.h>
1313
#import <React/RCTBridge.h>
@@ -19,7 +19,7 @@
1919

2020
#import "RCTTextSelection.h"
2121

22-
@implementation RCTTextInput {
22+
@implementation RCTBaseTextInputView {
2323
CGSize _previousContentSize;
2424
BOOL _hasInputAccesoryView;
2525
}
@@ -44,7 +44,7 @@ - (instancetype)initWithBridge:(RCTBridge *)bridge
4444

4545
- (id<RCTBackedTextInputViewProtocol>)backedTextInputView
4646
{
47-
RCTAssert(NO, @"-[RCTTextInput backedTextInputView] must be implemented in subclass.");
47+
RCTAssert(NO, @"-[RCTBaseTextInputView backedTextInputView] must be implemented in subclass.");
4848
return nil;
4949
}
5050

File renamed without changes.
File renamed without changes.

‎Libraries/Text/RCTShadowTextField.h ‎Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputShadowView.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99

1010
#import <React/RCTShadowView.h>
1111

12-
@interface RCTShadowTextField : RCTShadowView
12+
@interface RCTSinglelineTextInputShadowView : RCTShadowView
1313

1414
@end

‎Libraries/Text/RCTShadowTextField.m ‎Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputShadowView.m

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTShadowTextField.h"
10+
#import "RCTSinglelineTextInputShadowView.h"
1111

12-
@implementation RCTShadowTextField
12+
@implementation RCTSinglelineTextInputShadowView
1313

1414
- (BOOL)isYogaLeafNode
1515
{

‎Libraries/Text/RCTTextField.h ‎Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputView.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
#import <React/RCTComponent.h>
1313
#import <React/RCTView.h>
1414

15-
#import "RCTTextInput.h"
15+
#import "RCTBaseTextInputView.h"
1616

1717
@class RCTUITextField;
1818

19-
@interface RCTTextField : RCTTextInput
19+
@interface RCTSinglelineTextInputView : RCTBaseTextInputView
2020

2121
@property (nonatomic, assign) BOOL caretHidden;
2222
@property (nonatomic, strong) NSNumber *maxLength;

‎Libraries/Text/RCTTextField.m ‎Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputView.m

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTTextField.h"
10+
#import "RCTSinglelineTextInputView.h"
1111

1212
#import <React/RCTBridge.h>
1313
#import <React/RCTConvert.h>
@@ -21,11 +21,11 @@
2121
#import "RCTTextSelection.h"
2222
#import "RCTUITextField.h"
2323

24-
@interface RCTTextField () <RCTBackedTextInputDelegate>
24+
@interface RCTSinglelineTextInputView () <RCTBackedTextInputDelegate>
2525

2626
@end
2727

28-
@implementation RCTTextField
28+
@implementation RCTSinglelineTextInputView
2929
{
3030
RCTUITextField *_backedTextInput;
3131
BOOL _submitted;

‎Libraries/Text/RCTTextManager.h ‎Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputViewManager.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99

1010
#import <React/RCTViewManager.h>
1111

12-
@interface RCTTextManager : RCTViewManager
12+
@interface RCTSinglelineTextInputViewManager : RCTViewManager
1313

1414
@end

‎Libraries/Text/RCTTextFieldManager.m ‎Libraries/Text/TextInput/Singleline/RCTSinglelineTextInputViewManager.m

+8-8
Original file line numberDiff line numberDiff line change
@@ -7,30 +7,30 @@
77
* of patent rights can be found in the PATENTS file in the same directory.
88
*/
99

10-
#import "RCTTextFieldManager.h"
10+
#import "RCTSinglelineTextInputViewManager.h"
1111

1212
#import <React/RCTBridge.h>
1313
#import <React/RCTFont.h>
1414
#import <React/RCTShadowView+Layout.h>
1515
#import <React/RCTShadowView.h>
1616

1717
#import "RCTConvert+Text.h"
18-
#import "RCTShadowTextField.h"
19-
#import "RCTTextField.h"
18+
#import "RCTSinglelineTextInputShadowView.h"
19+
#import "RCTSinglelineTextInputView.h"
2020
#import "RCTUITextField.h"
2121

22-
@implementation RCTTextFieldManager
22+
@implementation RCTSinglelineTextInputViewManager
2323

2424
RCT_EXPORT_MODULE()
2525

2626
- (RCTShadowView *)shadowView
2727
{
28-
return [RCTShadowTextField new];
28+
return [RCTSinglelineTextInputShadowView new];
2929
}
3030

3131
- (UIView *)view
3232
{
33-
return [[RCTTextField alloc] initWithBridge:self.bridge];
33+
return [[RCTSinglelineTextInputView alloc] initWithBridge:self.bridge];
3434
}
3535

3636
#pragma mark - Unified <TextInput> properties
@@ -74,8 +74,8 @@ - (RCTViewManagerUIBlock)uiBlockToAmendWithShadowView:(RCTShadowView *)shadowVie
7474
NSNumber *reactTag = shadowView.reactTag;
7575
UIEdgeInsets borderAsInsets = shadowView.borderAsInsets;
7676
UIEdgeInsets paddingAsInsets = shadowView.paddingAsInsets;
77-
return ^(RCTUIManager *uiManager, NSDictionary<NSNumber *, RCTTextInput *> *viewRegistry) {
78-
RCTTextInput *view = viewRegistry[reactTag];
77+
return ^(RCTUIManager *uiManager, NSDictionary<NSNumber *, RCTBaseTextInputView *> *viewRegistry) {
78+
RCTBaseTextInputView *view = viewRegistry[reactTag];
7979
view.reactBorderInsets = borderAsInsets;
8080
view.reactPaddingInsets = paddingAsInsets;
8181
};

‎React/React.xcodeproj/project.pbxproj

+24
Original file line numberDiff line numberDiff line change
@@ -1082,6 +1082,14 @@
10821082
59D031FA1F8353D3008361F0 /* RCTSafeAreaViewManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 59D031EB1F8353D3008361F0 /* RCTSafeAreaViewManager.h */; };
10831083
59D031FB1F8353D3008361F0 /* RCTSafeAreaViewManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 59D031EC1F8353D3008361F0 /* RCTSafeAreaViewManager.m */; };
10841084
59D031FC1F8353D3008361F0 /* RCTSafeAreaViewManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 59D031EC1F8353D3008361F0 /* RCTSafeAreaViewManager.m */; };
1085+
59E604A01FE9CCE300BD90C5 /* RCTScrollContentShadowView.h in Headers */ = {isa = PBXBuildFile; fileRef = 59E6049C1FE9CCE100BD90C5 /* RCTScrollContentShadowView.h */; };
1086+
59E604A11FE9CCE300BD90C5 /* RCTScrollContentShadowView.h in Headers */ = {isa = PBXBuildFile; fileRef = 59E6049C1FE9CCE100BD90C5 /* RCTScrollContentShadowView.h */; };
1087+
59E604A21FE9CCE300BD90C5 /* RCTScrollContentViewManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 59E6049D1FE9CCE200BD90C5 /* RCTScrollContentViewManager.m */; };
1088+
59E604A31FE9CCE300BD90C5 /* RCTScrollContentViewManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 59E6049D1FE9CCE200BD90C5 /* RCTScrollContentViewManager.m */; };
1089+
59E604A41FE9CCE300BD90C5 /* RCTScrollContentShadowView.m in Sources */ = {isa = PBXBuildFile; fileRef = 59E6049E1FE9CCE200BD90C5 /* RCTScrollContentShadowView.m */; };
1090+
59E604A51FE9CCE300BD90C5 /* RCTScrollContentShadowView.m in Sources */ = {isa = PBXBuildFile; fileRef = 59E6049E1FE9CCE200BD90C5 /* RCTScrollContentShadowView.m */; };
1091+
59E604A61FE9CCE300BD90C5 /* RCTScrollContentViewManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 59E6049F1FE9CCE200BD90C5 /* RCTScrollContentViewManager.h */; };
1092+
59E604A71FE9CCE300BD90C5 /* RCTScrollContentViewManager.h in Headers */ = {isa = PBXBuildFile; fileRef = 59E6049F1FE9CCE200BD90C5 /* RCTScrollContentViewManager.h */; };
10851093
59EB6DBB1EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.h in Headers */ = {isa = PBXBuildFile; fileRef = 59EB6DB91EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.h */; };
10861094
59EB6DBC1EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.h in Headers */ = {isa = PBXBuildFile; fileRef = 59EB6DB91EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.h */; };
10871095
59EB6DBD1EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.mm in Sources */ = {isa = PBXBuildFile; fileRef = 59EB6DBA1EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.mm */; };
@@ -2192,6 +2200,10 @@
21922200
59D031EA1F8353D3008361F0 /* RCTSafeAreaViewLocalData.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RCTSafeAreaViewLocalData.m; sourceTree = "<group>"; };
21932201
59D031EB1F8353D3008361F0 /* RCTSafeAreaViewManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RCTSafeAreaViewManager.h; sourceTree = "<group>"; };
21942202
59D031EC1F8353D3008361F0 /* RCTSafeAreaViewManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RCTSafeAreaViewManager.m; sourceTree = "<group>"; };
2203+
59E6049C1FE9CCE100BD90C5 /* RCTScrollContentShadowView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RCTScrollContentShadowView.h; sourceTree = "<group>"; };
2204+
59E6049D1FE9CCE200BD90C5 /* RCTScrollContentViewManager.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RCTScrollContentViewManager.m; sourceTree = "<group>"; };
2205+
59E6049E1FE9CCE200BD90C5 /* RCTScrollContentShadowView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = RCTScrollContentShadowView.m; sourceTree = "<group>"; };
2206+
59E6049F1FE9CCE200BD90C5 /* RCTScrollContentViewManager.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RCTScrollContentViewManager.h; sourceTree = "<group>"; };
21952207
59EB6DB91EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RCTUIManagerObserverCoordinator.h; sourceTree = "<group>"; };
21962208
59EB6DBA1EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = RCTUIManagerObserverCoordinator.mm; sourceTree = "<group>"; };
21972209
59EDBC9C1FDF4E0C003573DE /* RCTScrollableProtocol.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RCTScrollableProtocol.h; sourceTree = "<group>"; };
@@ -2805,8 +2817,12 @@
28052817
isa = PBXGroup;
28062818
children = (
28072819
59EDBC9C1FDF4E0C003573DE /* RCTScrollableProtocol.h */,
2820+
59E6049C1FE9CCE100BD90C5 /* RCTScrollContentShadowView.h */,
2821+
59E6049E1FE9CCE200BD90C5 /* RCTScrollContentShadowView.m */,
28082822
59EDBC9F1FDF4E0C003573DE /* RCTScrollContentView.h */,
28092823
59EDBCA01FDF4E0C003573DE /* RCTScrollContentView.m */,
2824+
59E6049F1FE9CCE200BD90C5 /* RCTScrollContentViewManager.h */,
2825+
59E6049D1FE9CCE200BD90C5 /* RCTScrollContentViewManager.m */,
28102826
59EDBCA31FDF4E0C003573DE /* RCTScrollView.h */,
28112827
59EDBCA41FDF4E0C003573DE /* RCTScrollView.m */,
28122828
59EDBCA51FDF4E0C003573DE /* RCTScrollViewManager.h */,
@@ -3210,6 +3226,7 @@
32103226
66CD94B21F1045E700CB3C7C /* RCTMaskedView.h in Headers */,
32113227
3D302F8D1DF828F800D6DDAE /* RCTSegmentedControlManager.h in Headers */,
32123228
3D302F8E1DF828F800D6DDAE /* RCTShadowView.h in Headers */,
3229+
59E604A11FE9CCE300BD90C5 /* RCTScrollContentShadowView.h in Headers */,
32133230
3D302F8F1DF828F800D6DDAE /* RCTSlider.h in Headers */,
32143231
3D302F901DF828F800D6DDAE /* RCTSliderManager.h in Headers */,
32153232
3D302F911DF828F800D6DDAE /* RCTSwitch.h in Headers */,
@@ -3219,6 +3236,7 @@
32193236
3D302F951DF828F800D6DDAE /* RCTTabBarItemManager.h in Headers */,
32203237
59EDBCAE1FDF4E0C003573DE /* RCTScrollContentView.h in Headers */,
32213238
3D302F961DF828F800D6DDAE /* RCTTabBarManager.h in Headers */,
3239+
59E604A71FE9CCE300BD90C5 /* RCTScrollContentViewManager.h in Headers */,
32223240
3D302F971DF828F800D6DDAE /* RCTTextDecorationLineType.h in Headers */,
32233241
3D302F981DF828F800D6DDAE /* RCTView.h in Headers */,
32243242
3D302F991DF828F800D6DDAE /* RCTViewControllerProtocol.h in Headers */,
@@ -3445,6 +3463,7 @@
34453463
3D80DA3F1DF820620028D040 /* RCTRootViewInternal.h in Headers */,
34463464
3D80DA401DF820620028D040 /* RCTTouchEvent.h in Headers */,
34473465
3D80DA411DF820620028D040 /* RCTTouchHandler.h in Headers */,
3466+
59E604A61FE9CCE300BD90C5 /* RCTScrollContentViewManager.h in Headers */,
34483467
13134C8C1E296B2A00B9F3CB /* RCTMessageThread.h in Headers */,
34493468
59EB6DBB1EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.h in Headers */,
34503469
3D80DA421DF820620028D040 /* RCTURLRequestDelegate.h in Headers */,
@@ -3475,6 +3494,7 @@
34753494
3D80DA5A1DF820620028D040 /* RCTUIManager.h in Headers */,
34763495
3D80DA5B1DF820620028D040 /* RCTFPSGraph.h in Headers */,
34773496
FEFAAC9F1FDB89B50057BBE0 /* RCTRedBoxExtraDataViewController.h in Headers */,
3497+
59E604A01FE9CCE300BD90C5 /* RCTScrollContentShadowView.h in Headers */,
34783498
3D80DA5D1DF820620028D040 /* RCTMacros.h in Headers */,
34793499
3D80DA5E1DF820620028D040 /* RCTProfile.h in Headers */,
34803500
3D80DA5F1DF820620028D040 /* RCTActivityIndicatorView.h in Headers */,
@@ -4108,6 +4128,7 @@
41084128
2D3B5EE31D9B09B700451313 /* RCTSegmentedControl.m in Sources */,
41094129
130443A41E3FEAC600D93A67 /* RCTFollyConvert.mm in Sources */,
41104130
3D7BFD201EA8E351008DFB7A /* RCTPackagerConnection.mm in Sources */,
4131+
59E604A51FE9CCE300BD90C5 /* RCTScrollContentShadowView.m in Sources */,
41114132
5960C1B81F0804A00066FD5B /* RCTLayoutAnimation.m in Sources */,
41124133
2D3B5EB71D9B091800451313 /* RCTRedBox.m in Sources */,
41134134
3D7AA9C61E548CDD001955CF /* NSDataBigString.mm in Sources */,
@@ -4142,6 +4163,7 @@
41424163
EBF21C001FC499A80052F4D5 /* InspectorInterfaces.cpp in Sources */,
41434164
597633371F4E021D005BE8A4 /* RCTShadowView+Internal.m in Sources */,
41444165
2D3B5EB11D9B090100451313 /* RCTAppState.m in Sources */,
4166+
59E604A31FE9CCE300BD90C5 /* RCTScrollContentViewManager.m in Sources */,
41454167
1384E20B1E806D5B00545659 /* RCTNativeModule.mm in Sources */,
41464168
2D3B5EC21D9B093B00451313 /* RCTProfile.m in Sources */,
41474169
2D3B5ECB1D9B096200451313 /* RCTConvert+CoreLocation.m in Sources */,
@@ -4374,6 +4396,7 @@
43744396
C60128AD1F3D1258009DF9FF /* RCTCxxConvert.m in Sources */,
43754397
83CBBA511A601E3B00E9B192 /* RCTAssert.m in Sources */,
43764398
59EB6DBD1EBD6FC90072A5E7 /* RCTUIManagerObserverCoordinator.mm in Sources */,
4399+
59E604A21FE9CCE300BD90C5 /* RCTScrollContentViewManager.m in Sources */,
43774400
13AF20451AE707F9005F5298 /* RCTSlider.m in Sources */,
43784401
130443A21E3FEAA900D93A67 /* RCTFollyConvert.mm in Sources */,
43794402
58114A501AAE93D500E7D092 /* RCTAsyncLocalStorage.m in Sources */,
@@ -4402,6 +4425,7 @@
44024425
14F7A0EC1BDA3B3C003C6C10 /* RCTPerfMonitor.m in Sources */,
44034426
5960C1B71F0804A00066FD5B /* RCTLayoutAnimation.m in Sources */,
44044427
13134C9E1E296B2A00B9F3CB /* RCTCxxModule.mm in Sources */,
4428+
59E604A41FE9CCE300BD90C5 /* RCTScrollContentShadowView.m in Sources */,
44054429
1450FF881BCFF28A00208362 /* RCTProfileTrampoline-arm64.S in Sources */,
44064430
13E41EEB1C05CA0B00CD8DAC /* RCTProfileTrampoline-i386.S in Sources */,
44074431
3D37B5821D522B190042D5B5 /* RCTFont.mm in Sources */,

‎React/Views/RCTShadowView.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, UIView *> *viewRegistry
246246

247247
/**
248248
* Returns whether or not this node acts as a leaf node in the eyes of Yoga.
249-
* For example `RCTShadowText` has children which it does not want Yoga
249+
* For example `RCTTextShadowView` has children which it does not want Yoga
250250
* to lay out so in the eyes of Yoga it is a leaf node.
251251
* Defaults to `NO`. Can be overridden in subclasses.
252252
* Don't confuse this with `canHaveSubviews`.

‎React/Views/RCTShadowView.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ - (void)collectUpdatedFrames:(NSMutableSet<RCTShadowView *> *)viewsWithNewFrame
298298
hidden:(BOOL)hidden
299299
absolutePosition:(CGPoint)absolutePosition
300300
{
301-
// This is not the core layout method. It is only used by RCTShadowText to layout
301+
// This is not the core layout method. It is only used by RCTTextShadowView to layout
302302
// nested views.
303303

304304
if (_hidden != hidden) {

0 commit comments

Comments
 (0)
Please sign in to comment.