Skip to content

Commit 079bf3f

Browse files
ZdravkoNfacebook-github-bot
authored andcommittedJul 4, 2018
Packager linking when using custom debug configuration on iOS device (#16451)
Summary: In many projects we have different environments that we connect to. For these environments (for example: Test, Staging, Production) we have custom configurations (Debug and Release). While this is not a problem on Android, it is a problem on iOS. With the current implementation of the react-native-xcode.sh script, when using a custom Debug configuration, the app started on iOS device, can't contact the Packager. This pull request solves this issue. Connect a real device, start the app with a custom debug configuration in Xcode. Shake and Reload. [IOS][BUGFIX][./scripts/react-native-xcode.sh] Add support for connecting to the Packager when running the iOS app on device when using custom Debug configuration. Closes #16451 Differential Revision: D8730537 Pulled By: hramos fbshipit-source-id: a36007776e8fe9e401c38015040abd2c2bbd7c58
1 parent 33d20da commit 079bf3f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎scripts/react-native-xcode.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ type $NODE_BINARY >/dev/null 2>&1 || nodejs_not_found
9494
set -x
9595
DEST=$CONFIGURATION_BUILD_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH
9696

97-
if [[ "$CONFIGURATION" = "Debug" && ! "$PLATFORM_NAME" == *simulator ]]; then
97+
if [[ "$CONFIGURATION" = *Debug* && ! "$PLATFORM_NAME" == *simulator ]]; then
9898
IP=$(ipconfig getifaddr en0)
9999
if [ -z "$IP" ]; then
100100
IP=$(ifconfig | grep 'inet ' | grep -v ' 127.' | cut -d\ -f2 | awk 'NR==1{print $1}')

0 commit comments

Comments
 (0)
Please sign in to comment.