Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add note about yjs property syncing #7280

Open
etrepum opened this issue Mar 3, 2025 · 0 comments
Open

Documentation: Add note about yjs property syncing #7280

etrepum opened this issue Mar 3, 2025 · 0 comments

Comments

@etrepum
Copy link
Collaborator

etrepum commented Mar 3, 2025

lexical-collab will only reliably sync enumerable properties of nodes. This means that nodes participating in collab that are using properties instead of NodeState should initialize all of their properties in the constructor, even if to undefined.

We should probably also do a sweep over the existing nodes to make sure they all have explicit initializers (maybe write a lint to check for optional properties in node subclasses and disallow that syntax, foo: undefined | string will require explicit constructor initialization when foo?: string does not)

See also #7276, #7277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant