Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version of ESLint in the react-scripts package causing issues #6818

Closed
lffg opened this issue Apr 14, 2019 · 4 comments · Fixed by #6840
Closed

Fixed version of ESLint in the react-scripts package causing issues #6818

lffg opened this issue Apr 14, 2019 · 4 comments · Fixed by #6840
Assignees
Milestone

Comments

@lffg
Copy link
Contributor

lffg commented Apr 14, 2019

Is this a bug report?

Yes.

Did you try recovering your dependencies?

Yes.

Which terms did you search for in User Guide?

Not relevant.

Environment

Not relevant.

Steps to Reproduce

See this issue.

Expected Behavior

This error should not be happening.

Actual Behavior

There is an error because of the fixed ESLint version in the react-scripts package.

image

Question

Why does react-scripts keeps fixed versions of packages such as eslint in the dependency manifest? Why not just specify the major version, like eslint-config-react-app does (5.x, for example)?

https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/package.json#L40

Notice how eslint-config-react-app sets its ESLint version:
https://github.com/facebook/create-react-app/blob/master/packages/eslint-config-react-app/package.json#L17

@Delagardi
Copy link

same problem

@Goufix
Copy link

Goufix commented Apr 15, 2019

Same problem

@jbotSandbox
Copy link

I am having the same issue. And now I can't get eslint to work in VSCode (code-server). I followed the instructions where you remove node_modules, package-lock.json, yarn-lock.json and take out the reference to "eslint": "^5.16.0" out of the devDependencies of the package.json. But I left the references to eslink-plugins and eslink-config. Then I do a yarn or npm install.

Now I get the error in my output when VSCode tries to lint a file?

module.js:562
throw err;
^

Error: Cannot find module '/home/bitnami/testlint/-e'
at Function.Module._resolveFilename (module.js:560:15)
at Function.Module._load (module.js:487:25)
at Function.Module.runMain (module.js:726:10)
at startup (bootstrap_node.js:207:16)
at bootstrap_node.js:628:3

@iansu
Copy link
Contributor

iansu commented Apr 17, 2019

The maintainers discussed this issue today and we've decided to relax the ESLint version requirement. cc @ianschmitz

@iansu iansu added this to the 3.0 milestone Apr 17, 2019
@lock lock bot locked and limited conversation to collaborators Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants