Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade path-to-regexp to version 1.7.0 #4015

Closed
abumq opened this issue Jul 21, 2019 · 4 comments
Closed

Upgrade path-to-regexp to version 1.7.0 #4015

abumq opened this issue Jul 21, 2019 · 4 comments
Labels

Comments

@abumq
Copy link

abumq commented Jul 21, 2019

Is it safe to upgrade to version 1.7.0 of underlying path matching lib path-to-regexp? Latest i.e, version 3 but i am not fussed. I need features from version 1.7.0 specifically matching something like /user/(profile|settings)/:user_id

@dougwilson
Copy link
Contributor

Unfortunately it is not backwards compatible so cannot be upgraded in express 4.x. It will be upgraded in the next express 5.x release coming shortly, though.

@Emuentes
Copy link

@abumusamq Do you feel that the question was addressed?

If so, would it be alright to close the issue?

Just thinking of keeping the issues list down to the items that still need to be addressed to maximize the value of the limited time the maintainers have to review issues.

@wesleytodd
Copy link
Member

Also for reference: pillarjs/router#42

For express 5.0 the package will be a transitive dependency via router. Once that Pr is merged, you can use the 2.0 version of the router in any existing express app:

Then in your app:

const router = require('router')

app.use(router)

Hope that helps!

@abumq abumq closed this as completed Aug 19, 2019
@abumq
Copy link
Author

abumq commented Aug 19, 2019

all good. will wait for v5. Thanks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants