Skip to content
This repository was archived by the owner on Apr 24, 2022. It is now read-only.

Add changes to CHANGELOG file #1088

Closed
aleqx opened this issue May 8, 2018 · 20 comments
Closed

Add changes to CHANGELOG file #1088

aleqx opened this issue May 8, 2018 · 20 comments

Comments

@aleqx
Copy link

aleqx commented May 8, 2018

I'm sure I'm not the only one who would be very grateful if you guys posted change logs on the release pages, even if brief.

What are the changes from 13->14?

What about 14->15?

@invidtiv
Copy link

invidtiv commented May 8, 2018

I m not a dev, and I also share the same point as you, I know that it is long to actually understand the changes, but let the devs work on the ethminer, please don t add tasks to them...
I know your point , but understand that living the project grow these last few month , I do understand the lack of logs and so fourth...
Read all the push request that got aproved, you will catch on rapidly to all that is going on. and the changes If you need help, someone will help...
Hope you understand my point of view.

@aleqx
Copy link
Author

aleqx commented May 8, 2018

I was saying I'd be grateful for even brief logs, as in a couple of lines/handful of words.

@Dave-Snigier
Copy link

From my experience, changelogs cut down on misunderstandings and clarify what is expected behavior versus a bug. I don't think it's unreasonable to keep one that is concise. Should have a positive impact pn their time if the developers choose to create one.

@AndreaLanfranchi
Copy link
Collaborator

As I always reiterate Github itself is a huge changelog system.
It's not as simple as you may wish but it keeps track of every addition/deletion performed. Yeah I know ... you have to be able to read (and understand) code.

Simplified changelogs for "end-users" would be great but they need time to be collected, mantained, explained and ... as we all use our spare time, I rather prefer use it to "implement" code than writing public documentation. If there's anyone willing to get in charge of this task is always welcome.

@julianpoemp
Copy link

julianpoemp commented May 9, 2018

@AndreaLanfranchi in my software projects I decided to use changelog generators. A good changelog generator is this one that Angular developers use: Every commit that should be added to the changelog should have a special syntax. If you use this syntax you don't have any overhead. The list of features, bug fixes, breaking changes etc. is generated automatically.

Example for a changelog from the Angular project

More information: conventional-changelog-cli, commitizen

@Hakkk2002
Copy link
Contributor

@julianpoemp Despite that you can opt commits in and out of the changelog using the generator, GitHub itself can also make comparison between changes to serve like a changelog, such as this one.

A common problem, with or without tools to filter a changelog, is that the commit descriptions are usually written as technical abstract and are difficult to understand. For example, I don't think things like

compiler-cli: reflect static methods added to classes in metadata (#21926) (eb8ddd2)

in your changelog make any sense to normal readers.

So still, in order to maintain a good and readable changelog, overhead and extra work is likely a must. The opposite is of course doing nothing and let GitHub handle the comparisons.

@julianpoemp
Copy link

julianpoemp commented May 9, 2018

@Hakkk2002 With this generator you could add easy to read short descriptions and technical descriptions in the long description section and you can omit commits that are not relevant for users.

For example:

  fix(general): fixed reboot problem with nvidia 390.48 driver (#896)
  
  Technical information

  fixed #896

This would generate:

Bug fixes:

The angular changelog I used before as an example is a changelog for devs, because only devs are using that repository. I think it makes sense for ethminer using a changelog generator. It's only a suggestion by me to meet the needs of a changelog without overhead for developers.

@invidtiv
Copy link

invidtiv commented May 9, 2018

I strongly believe the following, using the github to get to understand the changes is a bit hard, and does require some effort from the end user to actually understand the changes, but its there, all written down, all explained, just browse the closed merged pull request.
I realy do not believe that the extra work being handed down to the devs be requiring a changelog is a good thing, a lot work is needed somewere else than a changelog like bugs, new features, solving AMD issues with etherminer.

@chfast
Copy link
Contributor

chfast commented May 9, 2018

We will try to collect changelog starting from 0.16.

For 0.14 and 0.15 you can review all merged PR and make the list of changes out of it. If you did, send it to me to include it in the release notes.

@jean-m-cyr
Copy link
Contributor

In the past change notes were only appended to final releases. Currently neither 14, nor 15, have reached final status. Once 14 is declared final, I'll volunteer to collate the changes, if no one else does it.

@aleqx
Copy link
Author

aleqx commented May 9, 2018

@jean-m-cyr Awesome, thank you very much. Just very briefly outlining the major changes would be enough for me (i'm guessing others would be happy too) - I for one just want to know whether it's worth trying the new version depending on what features I care about.

@Sail86
Copy link

Sail86 commented May 10, 2018

Regarding this I sense a chance to contribute a tiny bit to the great! efforts you're doing here.
I appreciate all the work you're doing here and wish I could contribute some commits, but I'm way too unexperienced yet.

The following list aint complete yet and I do not claim 100% correctness. It's a changelog from v0.13.0 to v0.14.0rc10.

I tried to exclude fixes to recent feature commits, but as I mentioned, I'm a NOOB. ;-)

Bug Fixes

Cosmetics

Features / Optimizations


Regarding #838

Implement URI support for specifying pool all pool attributes.

Many of the current parameter options that are no longer necessary
are flagged at deprecated, but remain functional for backwards
compatibility. Presumably support for these would be dropped in
a future release.

In short, the new -P parameter allows specifying up to 6 pool
endpoints of the form scheme://user[:password]@hostname:port[/emailaddress]
For further information lookup --help


I hope this helps a bit.

Beside I can strongly recommend v0.15.0.dev8 upwards for CUDAminers, it rocks!
-> #1076 Fix cuda hash mis-count (stabilize hash rate)

@jean-m-cyr
Copy link
Contributor

@Sail86 Thanks... I'll start translating that!

@Mycopka
Copy link

Mycopka commented May 22, 2018

+1
I'm also share the same point as author of topic.

@chfast
Copy link
Contributor

chfast commented May 22, 2018

@chfast chfast changed the title change logs ... please! Add changes to CHANGELOG file Jun 4, 2018
@AndreaLanfranchi
Copy link
Collaborator

As changelog practice is effective since 0.16 this issue can be closed.

@aleqx
Copy link
Author

aleqx commented Oct 20, 2018

Hmm, I don't see any changelogs in 0.16.0 or 0.16.1 (there are for 0.14.0 and 0.15.0). Were they lost somehow?

@chfast
Copy link
Contributor

chfast commented Oct 20, 2018

They are not.

@aleqx
Copy link
Author

aleqx commented Oct 20, 2018

Sorry, you mean they do exist somewhere? If yes, where exactly? I checked the released files as well.

@chfast
Copy link
Contributor

chfast commented Oct 20, 2018

I mean that nobody has written any changelogs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants