Remove duplicate job test... does more harm than good!

 X 14:17:32 stratum  Duplicate job #99d1de93… discarded
 i 14:17:36 stratum  Job: #447e59f9… us1-etc.ethermine.org [54.177.207.188:5555]
 X 14:17:36 stratum  Duplicate job #447e59f9… discarded
 i 14:17:41 stratum  Job: #84034167… us1-etc.ethermine.org [54.177.207.188:5555]
 X 14:17:41 stratum  Duplicate job #84034167… discarded
 i 14:17:42 cuda-1   Solution: 0xe139927e7a7120fa
 i 14:17:42 stratum  **Accepted  73 ms. us1-etc.ethermine.org [54.177.207.188:5555]
 i 14:17:53 cuda-3   Solution: 0xe139947e8a30fb28
 i 14:17:53 stratum  **Accepted  73 ms. us1-etc.ethermine.org [54.177.207.188:5555]
 m 14:17:58 ethminer Speed 85.70 Mh/s gpu0 22.25 gpu1 18.61 gpu2 22.42 gpu3 22.41 [A168+2] Time: 01:58
 i 14:18:11 stratum  Job: #f8e8f361… us1-etc.ethermine.org [54.177.207.188:5555]
 X 14:18:11 stratum  Duplicate job #f8e8f361… discarded
 i 14:18:25 cuda-0   Solution: 0xe139917e8cd7d0e4
 i 14:18:26 stratum  **Accepted  73 ms. us1-etc.ethermine.org [54.177.207.188:5555]
 i 14:18:27 stratum  Job: #85308bdd… us1-etc.ethermine.org [54.177.207.188:5555]
 X 14:18:27 stratum  Duplicate job #85308bdd… discarded
 m 14:18:28 ethminer Speed 85.70 Mh/s gpu0 22.25 gpu1 18.62 gpu2 22.43 gpu3 22.41 [A169+2] Time: 01:58
 i 14:18:29 cuda-0   Solution: 0xe139917e7c721ed9
 i 14:18:29 stratum  **Accepted  74 ms. us1-etc.ethermine.org [54.177.207.188:5555]
 i 14:18:32 cuda-3   Solution: 0xe139947e804d2f62
 i 14:18:32 stratum  **Accepted  74 ms. us1-etc.ethermine.org [54.177.207.188:5555]
 i 14:18:37 stratum  Job: #d402e39b… us1-etc.ethermine.org [54.177.207.188:5555]
 X 14:18:37 stratum  Duplicate job #d402e39b… discarded
 i 14:18:44 stratum  Job: #a14b8581… us1-etc.ethermine.org [54.177.207.188:5555]
 X 14:18:44 stratum  Duplicate job #a14b8581… discarded
 i 14:18:45 stratum  Job: #4732a304… us1-etc.ethermine.org [54.177.207.188:5555]

Author: jean-m-cyr

libpoolprotocols/PoolManager.cpp

@@ -70,22 +70,6 @@ PoolManager::PoolManager(boost::asio::io_service& io_service, PoolClient* client
     });
 
     p_client->onWorkReceived([&](WorkPackage const& wp) {
-        for (auto w : m_works)
-            /*
-            In ethereumstratum mode (nicehash) we might receive the same
-            job id after a change of extraNonce.
-            In other stratum modes extraNonce is not set so only equality
-            for header would be relevant
-            */
-            if (w.header == wp.header && w.startNonce == wp.startNonce)
-            {
-                cwarn << EthYellow "Duplicate job #" << wp.header.abridged()
-                      << " discarded" EthReset;
-                return;
-            }
-        m_works.push_back(wp);
-        if (m_works.size() > 4)
-            m_works.pop_front();
 
         cnote << "Job: " EthWhite "#" << wp.header.abridged() << EthReset " "
               << m_connections.at(m_activeConnectionIdx).Host() << p_client->ActiveEndPoint();
@@ -283,7 +267,6 @@ void PoolManager::workLoop()
 
                     // Clean any list of jobs inherited from
                     // previous connection
-                    m_works.clear();
 
                     p_client->connect();
                 }

libpoolprotocols/PoolManager.h

@@ -53,7 +53,6 @@ class PoolManager
     std::thread m_workThread;
 
     h256 m_lastBoundary = h256();
-    std::list<WorkPackage> m_works;
 
     boost::asio::io_service::strand m_io_strand;
     boost::asio::deadline_timer m_failovertimer;