Fix a bunch of cppcheck warnings

Author: jean-m-cyr

libapicore/httpServer.h

@@ -6,6 +6,7 @@
 class httpServer
 {
 public:
+	httpServer() {};
     void run(unsigned short port, dev::eth::Farm* farm, bool show_hwmonitors, bool show_power);
     void run_thread();
     void getstat1(stringstream& ss);

libdevcore/Exceptions.h

@@ -34,7 +34,7 @@ namespace dev
 /// Base class for all exceptions.
 struct Exception: virtual std::exception, virtual boost::exception
 {
-	Exception(std::string _message = std::string()): m_message(std::move(_message)) {}
+	Exception(const std::string& _message = std::string()): m_message(std::move(_message)) {}
 	const char* what() const noexcept override { return m_message.empty() ? std::exception::what() : m_message.c_str(); }
 
 private:
@@ -44,7 +44,7 @@ struct Exception: virtual std::exception, virtual boost::exception
 #define DEV_SIMPLE_EXCEPTION(X) struct X: virtual Exception { const char* what() const noexcept override { return #X; } }
 
 /// Base class for all RLP exceptions.
-struct RLPException: virtual Exception { RLPException(std::string _message = std::string()): Exception(_message) {} };
+struct RLPException: virtual Exception { RLPException(const std::string& _message = std::string()): Exception(_message) {} };
 #define DEV_SIMPLE_EXCEPTION_RLP(X) struct X: virtual RLPException { const char* what() const noexcept override { return #X; } }
 
 DEV_SIMPLE_EXCEPTION_RLP(BadCast);
@@ -54,7 +54,7 @@ DEV_SIMPLE_EXCEPTION_RLP(UndersizeRLP);
 
 DEV_SIMPLE_EXCEPTION(BadHexCharacter);
 
-struct ExternalFunctionFailure: virtual Exception { public: ExternalFunctionFailure(std::string _f): Exception("Function " + _f + "() failed.") {} };
+struct ExternalFunctionFailure: virtual Exception { public: ExternalFunctionFailure(const std::string& _f): Exception("Function " + _f + "() failed.") {} };
 
 // error information to be added to exceptions
 using errinfo_invalidSymbol = boost::error_info<struct tag_invalidSymbol, char>;

libethash-cl/CLMiner.cpp

@@ -663,11 +663,11 @@ bool CLMiner::init(int epoch)
         try
         {
             program.build({device}, options);
-            cwarn << "OpenCL kernel build log:\n"
-                  << program.getBuildInfo<CL_PROGRAM_BUILD_LOG>(device);
         }
         catch (cl::BuildError const& buildErr)
         {
+            cwarn << "OpenCL kernel build log:\n"
+                  << program.getBuildInfo<CL_PROGRAM_BUILD_LOG>(device);
             cwarn << "OpenCL kernel build error (" << buildErr.err() << "):\n" << buildErr.what();
             return false;
         }

libethash-cuda/ethash_cuda_miner_kernel.h

@@ -80,7 +80,7 @@ void ethash_generate_dag(
 
 struct cuda_runtime_error : public virtual std::runtime_error
 {
-	cuda_runtime_error( std::string msg ) : std::runtime_error(msg) {}
+	cuda_runtime_error( const std::string &msg ) : std::runtime_error(msg) {}
 };
 
 #define CUDA_SAFE_CALL(call)				\

libhwmon/wrapamdsysfs.cpp

@@ -110,7 +110,7 @@ wrap_amdsysfs_handle * wrap_amdsysfs_create()
 
 		// search hwmon
 		errno = 0;
-		snprintf(dbuf, 120, "/sys/class/drm/card%u/device/hwmon", sysfsIdx);
+		snprintf(dbuf, 120, "/sys/class/drm/card%d/device/hwmon", sysfsIdx);
 		DIR* dirp = opendir(dbuf);
 		if (dirp == nullptr) {
 			free(sysfsh);
@@ -179,7 +179,7 @@ wrap_amdsysfs_handle * wrap_amdsysfs_create()
 
 						int gpuindex = sysfsh->card_sysfs_device_id[i];
 						char dbuf[120];
-						snprintf(dbuf, 120, "/sys/class/drm/card%u/device/uevent", gpuindex);
+						snprintf(dbuf, 120, "/sys/class/drm/card%d/device/uevent", gpuindex);
 						std::ifstream ifs(dbuf, std::ios::binary);
 						std::string line;
 						int iBus = 0, iDevice = 0, iFunction = 0;
@@ -259,7 +259,7 @@ int wrap_amdsysfs_get_gpu_pci_id(wrap_amdsysfs_handle *sysfsh, int index, char *
 		return -1;
 
 	char dbuf[120];
-	snprintf(dbuf, 120, "/sys/class/drm/card%u/device/uevent", gpuindex);
+	snprintf(dbuf, 120, "/sys/class/drm/card%d/device/uevent", gpuindex);
 
 	std::ifstream ifs(dbuf, std::ios::binary);
 	std::string line;
@@ -287,7 +287,7 @@ int wrap_amdsysfs_get_tempC(wrap_amdsysfs_handle *sysfsh, int index, unsigned in
 		return -1;
 
 	char dbuf[120];
-	snprintf(dbuf, 120, "/sys/class/drm/card%u/device/hwmon/hwmon%u/temp1_input",
+	snprintf(dbuf, 120, "/sys/class/drm/card%d/device/hwmon/hwmon%d/temp1_input",
 		gpuindex, hwmonindex);
 
 	unsigned int temp = 0;
@@ -312,15 +312,15 @@ int wrap_amdsysfs_get_fanpcnt(wrap_amdsysfs_handle *sysfsh, int index, unsigned
 	unsigned int pwm = 0, pwmMax = 255, pwmMin = 0;
 
 	char dbuf[120];
-	snprintf(dbuf, 120, "/sys/class/drm/card%u/device/hwmon/hwmon%u/pwm1",
+	snprintf(dbuf, 120, "/sys/class/drm/card%d/device/hwmon/hwmon%d/pwm1",
 		gpuindex, hwmonindex);
 	getFileContentValue(dbuf, pwm);
 
-	snprintf(dbuf, 120, "/sys/class/drm/card%u/device/hwmon/hwmon%u/pwm1_max",
+	snprintf(dbuf, 120, "/sys/class/drm/card%d/device/hwmon/hwmon%d/pwm1_max",
 		gpuindex, hwmonindex);
 	getFileContentValue(dbuf, pwmMax);
 
-	snprintf(dbuf, 120, "/sys/class/drm/card%u/device/hwmon/hwmon%u/pwm1_min",
+	snprintf(dbuf, 120, "/sys/class/drm/card%d/device/hwmon/hwmon%d/pwm1_min",
 		gpuindex, hwmonindex);
 	getFileContentValue(dbuf, pwmMin);
 
@@ -337,7 +337,7 @@ int wrap_amdsysfs_get_power_usage(wrap_amdsysfs_handle* sysfsh, int index, unsig
             return -1;
 
         char dbuf[120];
-        snprintf(dbuf, 120, "/sys/kernel/debug/dri/%u/amdgpu_pm_info", gpuindex);
+        snprintf(dbuf, 120, "/sys/kernel/debug/dri/%d/amdgpu_pm_info", gpuindex);
 
         std::ifstream ifs(dbuf, std::ios::binary);
         std::string line;