Fix a bunch of coverity warnings

Some of these address warnings that are not really bugs, but could
be. These don't correct logic errors or affect performance, but cost
nothing to eliminate.

Others, like passing large vars by value have an effect on performance.

Author: jean-m-cyr

ethminer/main.cpp

@@ -858,47 +858,46 @@ class MinerCLI
 
 int main(int argc, char** argv)
 {
-	// Set env vars controlling GPU driver behavior.
-	setenv("GPU_MAX_HEAP_SIZE", "100");
-	setenv("GPU_MAX_ALLOC_PERCENT", "100");
-	setenv("GPU_SINGLE_ALLOC_PERCENT", "100");
+	try {
+		// Set env vars controlling GPU driver behavior.
+		setenv("GPU_MAX_HEAP_SIZE", "100");
+		setenv("GPU_MAX_ALLOC_PERCENT", "100");
+		setenv("GPU_SINGLE_ALLOC_PERCENT", "100");
 
-	MinerCLI m;
+		MinerCLI m;
 
-	m.ParseCommandLine(argc, argv);
+		m.ParseCommandLine(argc, argv);
 
-	if (getenv("SYSLOG"))
-		g_logSyslog = true;
-	if (g_logSyslog || (getenv("NO_COLOR")))
-		g_logNoColor = true;
+		if (getenv("SYSLOG"))
+			g_logSyslog = true;
+		if (g_logSyslog || (getenv("NO_COLOR")))
+			g_logNoColor = true;
 #if defined(_WIN32)
-	if (!g_logNoColor)
-	{
-		g_logNoColor = true;
-		// Set output mode to handle virtual terminal sequences
-		// Only works on Windows 10, but most users should use it anyway
-		HANDLE hOut = GetStdHandle(STD_OUTPUT_HANDLE);
-		if (hOut != INVALID_HANDLE_VALUE)
+		if (!g_logNoColor)
 		{
-			DWORD dwMode = 0;
-			if (GetConsoleMode(hOut, &dwMode))
+			g_logNoColor = true;
+			// Set output mode to handle virtual terminal sequences
+			// Only works on Windows 10, but most users should use it anyway
+			HANDLE hOut = GetStdHandle(STD_OUTPUT_HANDLE);
+			if (hOut != INVALID_HANDLE_VALUE)
 			{
-				dwMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
-				if (SetConsoleMode(hOut, dwMode))
-					g_logNoColor = false;
+				DWORD dwMode = 0;
+				if (GetConsoleMode(hOut, &dwMode))
+				{
+					dwMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
+					if (SetConsoleMode(hOut, dwMode))
+						g_logNoColor = false;
+				}
 			}
 		}
-	}
 #endif
 
-	try
-	{
 		m.execute();
 	}
 	catch (std::exception& ex)
 	{
 		cerr << "Error: " << ex.what() << "\n\n";
-		return 1;
+		return -1;
 	}
 
 	return 0;

libdevcore/Log.cpp

@@ -91,22 +91,28 @@ void dev::setThreadName(char const* _n)
 
 void dev::simpleDebugOut(std::string const& _s)
 {
-	if (!g_logNoColor)
-	{
-		std::cerr << _s + '\n';
-		return;
+	try {
+		if (!g_logNoColor)
+		{
+			std::cerr << _s + '\n';
+			return;
+		}
+		bool skip = false;
+		std::stringstream ss;
+		for (auto it : _s)
+		{
+			if (!skip && it == '\x1b')
+				skip = true;
+			else if (skip && it == 'm')
+				skip = false;
+			else if (!skip)
+				ss << it;
+		}
+		ss << '\n';
+		std::cerr << ss.str();
 	}
-	bool skip = false;
-	std::stringstream ss;
-	for (auto it : _s)
+	catch(...)
 	{
-		if (!skip && it == '\x1b')
-			skip = true;
-		else if (skip && it == 'm')
-			skip = false;
-		else if (!skip)
-			ss << it;
+		return;
 	}
-	ss << '\n';
-	std::cerr << ss.str();
 }

libethash-cuda/CUDAMiner.cpp

@@ -166,14 +166,14 @@ void CUDAMiner::setDevices(const vector<unsigned>& _devices, unsigned _selectedD
 
 unsigned CUDAMiner::getNumDevices()
 {
-    int deviceCount = -1;
+    int deviceCount;
     cudaError_t err = cudaGetDeviceCount(&deviceCount);
     if (err == cudaSuccess)
         return deviceCount;
 
     if (err == cudaErrorInsufficientDriver)
     {
-        int driverVersion = -1;
+        int driverVersion;
         cudaDriverGetVersion(&driverVersion);
         if (driverVersion == 0)
             throw std::runtime_error{"No CUDA driver found"};

libethash-cuda/CUDAMiner.h

@@ -102,11 +102,11 @@ class CUDAMiner: public Miner
 	hash128_t* m_dag = nullptr;
 	std::vector<hash64_t*> m_light;
 	int m_dag_size = -1;
-	uint32_t m_device_num;
+	uint32_t m_device_num = 0;
 
-	volatile search_results** m_search_buf;
-	cudaStream_t  * m_streams;
-	uint64_t m_current_target;
+	volatile search_results** m_search_buf = nullptr;
+	cudaStream_t* m_streams = nullptr;
+	uint64_t m_current_target = 0;
 
 	/// The local work size for the search
 	static unsigned s_blockSize;

libethcore/Farm.h

@@ -51,7 +51,7 @@ namespace eth
 class Farm: public FarmFace
 {
 public:
-	unsigned tstart, tstop;
+	unsigned tstart = 0, tstop = 0;
 
 	struct SealerDescriptor
 	{
@@ -538,7 +538,7 @@ class Farm: public FarmFace
 	uint64_t m_nonce_scrambler;
 	unsigned int m_nonce_segment_with = 40;				// This is the exponent of the power 2^n which determines the width of each search segment assigned to each gpu
 
-	unsigned m_tstart, m_tstop;
+	unsigned m_tstart = 0, m_tstop = 0;
 
 	wrap_nvml_handle *nvmlh = NULL;
 	wrap_adl_handle *adlh = NULL;

libpoolprotocols/PoolClient.h

@@ -29,7 +29,7 @@ namespace dev
 			virtual void disconnect() = 0;
 
 			virtual void submitHashrate(string const & rate) = 0;
-			virtual void submitSolution(Solution solution) = 0;
+			virtual void submitSolution(const Solution &solution) = 0;
 			virtual bool isConnected() = 0;
 			virtual bool isPendingState() = 0;
 			virtual string ActiveEndPoint() = 0;

libpoolprotocols/getwork/EthGetworkClient.cpp

@@ -56,7 +56,7 @@ void EthGetworkClient::submitHashrate(string const & rate)
 
 }
 
-void EthGetworkClient::submitSolution(Solution solution)
+void EthGetworkClient::submitSolution(const Solution& solution)
 {
 	// Immediately send found solution without wait for loop
 	if (m_connected || m_justConnected) {

libpoolprotocols/getwork/EthGetworkClient.h

@@ -25,7 +25,7 @@ class EthGetworkClient : public PoolClient, Worker
 	string ActiveEndPoint() override { return ""; };
 
 	void submitHashrate(string const & rate) override;
-	void submitSolution(Solution solution) override;
+	void submitSolution(const Solution& solution) override;
 
 private:
 	void workLoop() override;
@@ -35,7 +35,7 @@ class EthGetworkClient : public PoolClient, Worker
 
 	bool m_justConnected = false;
 	h256 m_client_id;
-	JsonrpcGetwork *p_client;
+	JsonrpcGetwork *p_client = nullptr;
 	WorkPackage m_prevWorkPackage;
 
 	// Hashrate submission is optional

libpoolprotocols/stratum/EthStratumClient.cpp

@@ -173,7 +173,8 @@ void EthStratumClient::disconnect()
 	}
 
 	// Cancel any outstanding async operation
-	m_socket->cancel();
+	if (m_socket)
+		m_socket->cancel();
 
 	m_io_service.post([&] {
 		m_conntimer.cancel();
@@ -1041,7 +1042,7 @@ void EthStratumClient::submitHashrate(string const & rate) {
 
 }
 
-void EthStratumClient::submitSolution(Solution solution) {
+void EthStratumClient::submitSolution(const Solution& solution) {
 
 	string nonceHex = toHex(solution.nonce);
 

libpoolprotocols/stratum/EthStratumClient.h

@@ -39,7 +39,7 @@ class EthStratumClient : public PoolClient
 	string ActiveEndPoint() override { return " [" + toString(m_endpoint) + "]"; };
 
 	void submitHashrate(string const & rate) override;
-	void submitSolution(Solution solution) override;
+	void submitSolution(const Solution &solution) override;
 
 	h256 currentHeaderHash() { return m_current.header; }
 	bool current() { return static_cast<bool>(m_current); }
@@ -111,7 +111,7 @@ class EthStratumClient : public PoolClient
 	h256 m_nextWorkBoundary = h256("0xffff000000000000000000000000000000000000000000000000000000000000");
 
 	h64 m_extraNonce;
-	int m_extraNonceHexSize;
+	int m_extraNonceHexSize = 0;
 
 	bool m_submit_hashrate;
 	std::string m_submit_hashrate_id;

libpoolprotocols/testing/SimulateClient.cpp

@@ -45,7 +45,7 @@ void SimulateClient::submitHashrate(string const & rate)
 	cnote << "On difficulty" << m_difficulty << "for" << sec.count() << "seconds";
 }
 
-void SimulateClient::submitSolution(Solution solution)
+void SimulateClient::submitSolution(const Solution& solution)
 {
 	m_uppDifficulty = true;
 	cnote << "Difficulty:" << m_difficulty;

libpoolprotocols/testing/SimulateClient.h

@@ -25,7 +25,7 @@ class SimulateClient : public PoolClient, Worker
 	string ActiveEndPoint() override { return ""; };
 
 	void submitHashrate(string const & rate) override;
-	void submitSolution(Solution solution) override;
+	void submitSolution(const Solution& solution) override;
 
 private:
 	void workLoop() override;