Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iot_usbh_cdc): Close 'extern C' block (AEGHB-1008) #482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Auster
Copy link

@Auster Auster commented Mar 12, 2025

Description

This PR fixes the issue by adding missed "}" at the end of the file.

Example error before the fix:

[EDITED]/managed_components/espressif__iot_usbh_cdc/include/iot_usbh_cdc.h:13:1: note: 'extern "C"' linkage started here
   13 | extern "C" {
      | ^~~~~~~~~~
/home/auster/.espressif/tools/xtensa-esp-elf/esp-13.2.0_20240530/xtensa-esp-elf/xtensa-esp-elf/include/c++/13.2.0/bits/algorithmfwd.h:631:3: error: template with C linkage
  631 |   template<typename _RAIter>
      |   ^~~~~~~~
[EDITED]/managed_components/espressif__iot_usbh_cdc/include/iot_usbh_cdc.h:13:1: note: 'extern "C"' linkage started here
   13 | extern "C" {
      | ^~~~~~~~~~
/home/auster/.espressif/tools/xtensa-esp-elf/esp-13.2.0_20240530/xtensa-esp-elf/xtensa-esp-elf/include/c++/13.2.0/bits/algorithmfwd.h:636:3: error: template with C linkage
  636 |   template<typename _RAIter, typename _Compare>
      |   ^~~~~~~~
[EDITED]/managed_components/espressif__iot_usbh_cdc/include/iot_usbh_cdc.h:13:1: note: 'extern "C"' linkage started here
   13 | extern "C" {
      | ^~~~~~~~~~
/home/auster/.espressif/tools/xtensa-esp-elf/esp-13.2.0_20240530/xtensa-esp-elf/xtensa-esp-elf/include/c++/13.2.0/bits/algorithmfwd.h:642:3: error: template with C linkage
  642 |   template<typename _BIter, typename _Predicate>
      |   ^~~~~~~~
[EDITED]/managed_components/espressif__iot_usbh_cdc/include/iot_usbh_cdc.h:13:1: note: 'extern "C"' linkage started here
   13 | extern "C" {
      | ^~~~~~~~~~
/home/auster/.espressif/tools/xtensa-esp-elf/esp-13.2.0_20240530/xtensa-esp-elf/xtensa-esp-elf/include/c++/13.2.0/bits/algorithmfwd.h:661:3: error: template with C linkage
  661 |   template<typename _FIter1, typename _FIter2>
      |   ^~~~~~~~
[EDITED]/managed_components/espressif__iot_usbh_cdc/include/iot_usbh_cdc.h:13:1: note: 'extern "C"' linkage started here
   13 | extern "C" {
      | ^~~~~~~~~~
/home/auster/.espressif/tools/xtensa-esp-elf/esp-13.2.0_20240530/xtensa-esp-elf/xtensa-esp-elf/include/c++/13.2.0/bits/algorithmfwd.h:668:3: error: template with C linkage
  668 |   template<typename _FIter>

After the fix, the error is gone.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Sorry, something went wrong.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Auster, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 238eb68

@github-actions github-actions bot changed the title fix(iot_usbh_cdc): Close 'extern C' block fix(iot_usbh_cdc): Close 'extern C' block (AEGHB-1008) Mar 12, 2025
Copy link
Collaborator

@leeebo leeebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Auster LGTM! Thanks!

@leeebo
Copy link
Collaborator

leeebo commented Mar 13, 2025

sha=238eb680616e602e11f101769fa12b0bc6b05b9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants