Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: emscripten-core/emscripten
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: bvibber/emscripten
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: intArrayToString
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Sep 21, 2019

  1. Update intArrayToString to match docs, and update docs 

    intArrayToString is documented as taking null-terminated input,
but previously did not stop at a 0 entry.

Switched it to use UTF8ArrayToString internally using the
array length as maximum length. This both fixes the discrepancy
with the documentation by allowing 0-terminated input arrays,
and improves general compatibility by allowing input data to
contain UTF-8 strings without being corrupted on output to
JavaScript.

Updated documentation for both intArrayToString and its
almost-inverse, intArrayFromString, to indicate that UTF-8
is used (this was already the case, but not documented,
for intArrayFromString).

Fixes #4840
    @bvibber
    bvibber committed Sep 21, 2019
    Copy the full SHA
    cc18cd8 View commit details
Loading