Move inversion step to right context

AdrianSosic · AdrianSosic · commit 4fdd6878d055 · 2025-01-22T14:19:30.000+01:00
Not all MC acquisitions functions use best_f (e.g. qUCB), causing a
KeyError in these cases
diff --git a/baybe/acquisition/base.py b/baybe/acquisition/base.py
@@ -111,11 +111,12 @@ def to_botorch(
                     additional_params["best_f"] = (
                         bo_surrogate.posterior(train_x).mean.min().item()
                     )
+                    if self.is_mc:
+                        additional_params["best_f"] *= -1.0
 
                 if issubclass(acqf_cls, bo_acqf.AnalyticAcquisitionFunction):
                     additional_params["maximize"] = False
-                elif issubclass(acqf_cls, bo_acqf.MCAcquisitionFunction):
-                    additional_params["best_f"] *= -1.0
+                elif self.is_mc:
                     additional_params["objective"] = LinearMCObjective(
                         torch.tensor([-1.0])
                     )

Original file line number	Diff line number	Diff line change
`@@ -111,11 +111,12 @@ def to_botorch(`
`111`	`111`	`additional_params["best_f"] = (`
`112`	`112`	`bo_surrogate.posterior(train_x).mean.min().item()`
`113`	`113`	`)`
	`114`	`+ if self.is_mc:`
	`115`	`+ additional_params["best_f"] *= -1.0`
`114`	`116`
`115`	`117`	`if issubclass(acqf_cls, bo_acqf.AnalyticAcquisitionFunction):`
`116`	`118`	`additional_params["maximize"] = False`
`117`		`- elif issubclass(acqf_cls, bo_acqf.MCAcquisitionFunction):`
`118`		`- additional_params["best_f"] *= -1.0`
	`119`	`+ elif self.is_mc:`
`119`	`120`	`additional_params["objective"] = LinearMCObjective(`
`120`	`121`	`torch.tensor([-1.0])`
`121`	`122`	`)`