Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ContainerDebugAdapter typedef is missing Ember Object import #20320

Closed
bwbuchanan opened this issue Dec 13, 2022 · 2 comments · Fixed by #20321
Closed

[Bug] ContainerDebugAdapter typedef is missing Ember Object import #20320

bwbuchanan opened this issue Dec 13, 2022 · 2 comments · Fixed by #20321

Comments

@bwbuchanan
Copy link

🐞 Describe the Bug

ember-source/types/preview/@ember/debug/container-debug-adapter.d.ts appears to be missing this line:

import Object from '@ember/object';

As a result, ContainerDebugAdapter is incorrectly typed as inheriting from JavaScript's Object instead of EmberObject.

This is blocking ember-cli/ember-resolver#795

🌍 Environment

  • Ember: 4.9.2
@chriskrycho chriskrycho linked a pull request Dec 13, 2022 that will close this issue
@chriskrycho
Copy link
Contributor

Thanks for the report! Should be resolved in a bit, and I'll publish the back-ports this afternoon or (more likely) tomorrow morning!

@chriskrycho
Copy link
Contributor

Fix going out in the latest versions of LTS, stable, and beta (all just released)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants