Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate inject export from @ember/service #20262

Closed
bertdeblock opened this issue Nov 9, 2022 · 3 comments · Fixed by #20526
Closed

Deprecate inject export from @ember/service #20262

bertdeblock opened this issue Nov 9, 2022 · 3 comments · Fixed by #20526

Comments

@bertdeblock
Copy link
Member

Since Ember v4.1.0, it's possible to use the service export coming from @ember/service.
This feature was suggested in RFC 752 and implemented in PR 19776.
This means that, at some point, we can deprecate inject in favor of service as having two things to accomplish the same thing is redundant. This issue serves as a reminder to implement that deprecation.

@bertdeblock
Copy link
Member Author

I'm guessing the main thing here is timing? The RFC states that the deprecation should be until v5, but introducing the deprecation too soon might be annoying for addons that want/need to support Ember versions older than v4.1?

@chriskrycho
Copy link
Contributor

I can bring it up at a Framework meeting soon. I don’t think the timing issue should be a big deal: by the time 5.0 comes out 3.28 will no longer be an LTS, and in fact 4.4 will be nearing the end of its LTS.

@bertdeblock
Copy link
Member Author

Great, feel free to ping me once discussed, I can do the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants