Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecation Tests] Usage of window.ENV in tests/index.html #18459

Closed
Alonski opened this issue Oct 3, 2019 · 2 comments
Closed

[Deprecation Tests] Usage of window.ENV in tests/index.html #18459

Alonski opened this issue Oct 3, 2019 · 2 comments
Labels
Bug

Comments

@Alonski
Copy link
Member

Alonski commented Oct 3, 2019 •
edited
Loading

A recent PR introduced a deprecation for using window.ENV.
Tests Index.html is using this:
https://github.com/emberjs/ember.js/blob/master/tests/index.html#L41

Caused by: #18441
@rwjblue
Copy link
Member

rwjblue commented Oct 4, 2019

@astronomersiva - Think you might have a minute to shoot off a PR fixing?

@rwjblue rwjblue added the Bug label Oct 4, 2019
@Mikek2252 Mikek2252 mentioned this issue Oct 25, 2019
Merged
@rwjblue
Copy link
Member

rwjblue commented Oct 29, 2019

Closed by #18521

@rwjblue rwjblue closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @Alonski