Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] debug macros work incorrectly in 3.13.0-beta.3 #18294

Closed
lennyburdette opened this issue Aug 22, 2019 · 3 comments · Fixed by #18304
Closed

[beta] debug macros work incorrectly in 3.13.0-beta.3 #18294

lennyburdette opened this issue Aug 22, 2019 · 3 comments · Fixed by #18304
Milestone

Comments

@lennyburdette
Copy link
Contributor

Reproduction:

npx ember-cli new macro-test # will install 3.12
cd macro-test
$(npm bin)/ember build --environment production
grep "could not find a suitable method to bind" dist/assets/vendor-*.js
# note there's no output

npm install --save [email protected]
$(npm bin)/ember build --environment production
grep "could not find a suitable method to bind" dist/assets/vendor-*.js
# this will find the assert

The assert in question should be stripped from the build.

For whatever reason, leaving this assert in causes my app to fail to load in production, even though this test app works just fine.

cc @rwjblue

@rwjblue
Copy link
Member

rwjblue commented Aug 23, 2019

Reviewing the diff between production builds of 3.12 vs 3.13.0-beta.3 shows a few major differences:

  • no longer using enifed (we apparently swapped to using define again)
  • all debug statements are not stripped
  • the build size is ~ 30k larger (after min+gzip)

Definitely a pretty bad regression, thank you for reporting!

@rwjblue
Copy link
Member

rwjblue commented Aug 23, 2019

Fixed by #18304 and also pulled that change into the beta branch (for release in 3.13.0-beta.4 and also the general ember-beta ember-try scenarios).

@rwjblue
Copy link
Member

rwjblue commented Aug 23, 2019

Thanks again for reporting @lennyburdette!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants