-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort computed decorator in Octane gives "this.notifyPropertyChange is not a function" error #17839
Labels
Comments
Can you share the full stack trace? |
@rwjblue Sure thing:
|
The issue is here:
The reduced macros can absolutely not assume that I've submitted #17841 to fix. |
Thanks, running locally off of that PR's branch confirms that it fixes the issue for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm attempting to sort a list of Ember Data records, and add a new record to the list. In stable this works fine, but in Octane I get the following error (error shown is from Firefox):
Minimal reproduction: https://github.com/CodingItWrong/octane-sort-test
Comparable stable app showing the error does not occur: https://github.com/CodingItWrong/ember-sort-test
Here's the class where the sorting happens:
The text was updated successfully, but these errors were encountered: