Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES6 class syntax in 3.4.X: super.didReceiveAttrs is not a function #17546

Closed
cibernox opened this issue Feb 1, 2019 · 2 comments
Closed

ES6 class syntax in 3.4.X: super.didReceiveAttrs is not a function #17546

cibernox opened this issue Feb 1, 2019 · 2 comments

Comments

@cibernox
Copy link
Contributor

cibernox commented Feb 1, 2019

Updating ember-basic-dropdown to octane I found that it fails in 3.4 (works in newer versions) because super.didReceiveAttrs doesn't exist.

The best reproduction I can submit right now is the PR itself: cibernox/ember-basic-dropdown#446

Just clone, install dependencies, run ember serve and go to http://localhost:4200 and the error will be logged in the console.
@rwjblue
Copy link
Member

rwjblue commented Feb 3, 2019

This was fixed in #17169 which is included in 3.6+, but needs to be backported to lts-3-4 branch to fix 3.4.

@locks
Copy link
Contributor

locks commented Apr 19, 2020

Closing as no longer relevant. Please move to v3.8 as its the nearest LTS!

@locks locks closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwjblue @locks @cibernox