Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing docs for defineProperty #16790

Closed
jenweber opened this issue Jul 3, 2018 · 3 comments
Closed

Missing docs for defineProperty #16790

jenweber opened this issue Jul 3, 2018 · 3 comments

Comments

@jenweber
Copy link
Contributor

jenweber commented Jul 3, 2018

Help wanted: defineProperty is referenced as a solution to a 3.x deprecation, but it isn’t documented. It was last documented in 1.13.

To do:

  • look up the 1.13 docs
  • update them to use 3.x syntax for examples (the method is currently on @ember/object)
  • update the yuidoc reference, using the same format as similar methods like computed. We changed yuidoc syntax since 1.13
  • get a review of the PR from someone on Ember Core and the Learning Team
@ijlee2
Copy link
Member

ijlee2 commented Jul 3, 2018

I can help with updating the 3.x doc to include defineProperty.

@jenweber
Copy link
Contributor Author

jenweber commented Jul 4, 2018

PR #16791

@rwjblue
Copy link
Member

rwjblue commented Jul 9, 2018

Resolved by #16791

@rwjblue rwjblue closed this as completed Jul 9, 2018
@simonihmig simonihmig mentioned this issue Aug 1, 2018
Closed
@betocantu93 betocantu93 mentioned this issue Sep 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwjblue @jenweber @ijlee2