-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angle Bracket Invocation Syntax #16688
Labels
Comments
Updated checklist to mark off items from #16686. |
This was referenced May 25, 2018
Marked |
This was referenced May 30, 2018
Updated for items completed in #16704. |
This is now enabled by default on canary, and barring any additional issues will be included in the 3.4 series of releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Now that the Angle Bracket Invocation RFC has been merged (🎉) this issue aims to track landing the functionality proposed there behind the
EMBER_GLIMMER_ANGLE_BRACKET_INVOCATION
feature flag.Where possible individual items will cross link to the related section of the RFC.
Features
Ember.Component
based components via angle brackets with "capital case" component naming (e.g.<FooBar></FooBar>
would findapp/components/foo-bar.js
). Relevant RFC Section<FooBar @foo={{somethingSpecial}}></FooBar>
)....attributes
tagName
is not''
class
attribute should be merged with those in the specified elementhas-block
should befalse
for "self closing" invocations (e.g.<FooBar />
)has-block
should betrue
for normal (not self closing) invocations (e.g.<FooBar></FooBar>
)<this.foo></this.foo>
)<@foo></@foo>
)Implementation TODO's
simple-html-tokenizer
to support<@foo></@foo>
Allow@
to be the first char in a tag name. tildeio/simple-html-tokenizer#62 & Update simple-html-tokenizer to ^0.5.3. glimmerjs/glimmer-vm#818didCreateElement
on the component's manager for every usage of...attributes
DecoupledidCreateElement
from...attributes
. glimmerjs/glimmer-vm#820has-block
is false for self closing component invocations (e.g.<FooBar />
) Ensurehas-block
is false for<Foo />
. glimmerjs/glimmer-vm#819...attributes
in the Ember.Component wrapper element Add implicit ...attributes to wrapped layouts. glimmerjs/glimmer-vm#823The text was updated successfully, but these errors were encountered: