Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember.instrument misses compilation/lookup phase. #14974

Closed
stefanpenner opened this issue Mar 1, 2017 · 2 comments · Fixed by #15085
Closed

Ember.instrument misses compilation/lookup phase. #14974

stefanpenner opened this issue Mar 1, 2017 · 2 comments · Fixed by #15085

Comments

@stefanpenner
Copy link
Member

stefanpenner commented Mar 1, 2017

During initial render of a component the render.component subscription event does not include the compilation and module lookup times.

As this only happens the first time a class of component is rendered, it should likely be a new event. Maybe render.compile or render.setup.

Flame graph demonstrating the unclaimed time. Note: the darker/bolder highlights this unclaimed time.

missing-instrumentation-event


For reference, we noticed this while authoring ember-perf-timeline addon

@hjdivad & @stefanpenner

@rwjblue
Copy link
Member

rwjblue commented Mar 1, 2017

Seems good to me, likely fine to PR so we can review specific details...

@stefanpenner
Copy link
Member Author

Should be relatively straight forward, maybe someone has spare cycles to do this. (I don't really have cycles)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants