Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isStream should be flagged as a reserved property on Components #13271

Closed
noslouch opened this issue Apr 6, 2016 · 1 comment
Closed

isStream should be flagged as a reserved property on Components #13271

noslouch opened this issue Apr 6, 2016 · 1 comment
Labels

Comments

@noslouch
Copy link

noslouch commented Apr 6, 2016

See this twiddle for a reduced test case. Open the console to see the error message:

Uncaught TypeError: object.subscribe is not a function

If you set isStream as a property on a Component (at least, maybe other classes too), rendering borks because isStream is used internally. I can put together a failing test and possibly a PR, just wanted to note it here in case anyone else wants to pick it up.

I'm imagining a helpful error message at run time that just states that isStream is a reserved property name.

@mmun
Copy link
Member

mmun commented Apr 6, 2016

We should not be reserving isStream, instead we should change this branding to a symbol to avoid interfering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants