Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate usage of {{render helper with a model param. #13183

Closed
2 tasks
rwjblue opened this issue Mar 25, 2016 · 2 comments
Closed
2 tasks

Deprecate usage of {{render helper with a model param. #13183

rwjblue opened this issue Mar 25, 2016 · 2 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Mar 25, 2016

This is always better written today as a component invocation, we should deprecate this.

Bad:

{{render 'foo-bar' someModelThingy}}

Good:

{{foo-bar model=someModelThingy}}

  • AST transform to deprecate while compiling templates (to provide line number information)
  • Add deprecation guide entry in emberjs/website
@pittst3r
Copy link
Contributor

pittst3r commented Apr 6, 2016

I'll take a stab at this.

@rwjblue
Copy link
Member Author

rwjblue commented Apr 6, 2016

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants