Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component's Scope In A Component Block Is Incorrect #12409

Closed
chadhietala opened this issue Sep 29, 2015 · 4 comments
Closed

Component's Scope In A Component Block Is Incorrect #12409

chadhietala opened this issue Sep 29, 2015 · 4 comments

Comments

@chadhietala
Copy link
Contributor

I believe the scoping of actions with curly components is incorrect on canary. The canary JSBin illustrates that when a component is yielded in a component block that scope is changed.

Canary
http://jsbin.com/xetufateju/edit?html,css,js,console,output

Beta
http://emberjs.jsbin.com/noyawedime/1/edit?html,css,js,output

Release
http://emberjs.jsbin.com/cezumomapi/edit?html,css,js,output

/cc @wycats @chancancode

@chadhietala chadhietala changed the title Component's Scope A Component Block Is Incorrect Component's Scope In A Component Block Is Incorrect Sep 29, 2015
@rwjblue
Copy link
Member

rwjblue commented Sep 30, 2015

Thanks for reporting, this is definitely an issue with the recent removal of the controller and view template locals (done in #12286 around here).

Enabling those legacy flags does make this work properly (and is why the test suite passes). Will dig into it a bit more tonight...

@rwjblue rwjblue added this to the 2.2.0-beta.1 milestone Sep 30, 2015
@rwjblue
Copy link
Member

rwjblue commented Sep 30, 2015

Issue is with the @element_action keyword using scope.getLocal('controller').

@rwjblue
Copy link
Member

rwjblue commented Sep 30, 2015

Created failing test in: master...rwjblue:action-scoping. Working on fix tonight....

@rwjblue
Copy link
Member

rwjblue commented Oct 1, 2015

Submitted #12416 with a potential solution...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants