New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update {{each-in}} #11370

Closed

rwjblue opened this issue Jun 7, 2015 · 0 comments · Fixed by #11383

Assignees

Member

rwjblue commented Jun 7, 2015

https://github.com/emberjs/ember.js/blob/master/packages/ember-htmlbars/lib/helpers/each-in.js#L2-L8 should use the same shouldDisplay helper function that {{if}} and {{unless}} use.
Should use Ember.keys instead of hasOwnProperty to prevent a V8 deopt.

The text was updated successfully, but these errors were encountered:

rwjblue assigned tomdale

cibernox mentioned this issue

Update {{each-in}} to use ember-metal/should-display #11383

Merged

rwjblue closed this as completed in #11383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment