-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{{render 'navigation'}} won't render navigation.hbs if navigation view is present #10760
Comments
@kuzirashi sounds like a regression. A simple reproduction with emberjs.jsbin.com would be helpful, thanks. |
@mixonic Ember 1.10 working fine: Ember 1.11 bad: And gratis Ember 1.11 + templateName specified in view working fine: Also I have playlist.hbs:
I should probably be using components but it is somewhat old code and should just work. #edit So I started to refactor
Works fine. |
I think I hit the same thing when moving to 1.11.0 stable from 1.11.0-beta.5 when leveraging the {{render ".."}} helper (we'll have to switch it to a component soon enough). Chrome Canary has a better error:
|
Demos to recreate my and @hemp issue: Nested Nested |
+1, having same problems |
I'm having the same problem. I can work around it by explicitly setting the templateName in the view. |
Also running into this issue in 1.11 but, like @manufaktor, I'm finding if you explicitly specify |
I've also been bitten by this bug in the upgrade to Ember 1.11 from Ember 1.10. |
Confirmed here. Broken in 1.11 (unless templateName is explicitly defined on view); works in 1.11.0-beta.5. |
having this issue too |
Looks related to #10710 (comment) (which was addressed in #10712). |
thanks @rwjblue! so the expected behavior is to always define the |
@davidpett - Yes, I am now questioning the change made in #10712. This seems to be a regression, though it does solve the issue from #10710. I will try to dig into this tonight/tomorrow morning, and try to fix both the issue in #10710 and not break this use case. |
@rwjblue I'm also seeing some errors in |
thanks @rwjblue |
@rwjblue Here is an example of the error described in my previous comment: http://emberjs.jsbin.com/feyakinure/1/edit?html,js,output |
my app is totally broken by this but I've already started using the new {{component}} helper (which is awesome btw). Any chance of a patch release? |
as far as I can tell it just breaks because its trying to find the top level "outlet" but doesn't stop when it finds it? in function impersonateAnOutlet(currentView, view, name) while (pointer && pointer._parentOutlet!=undefined && (po = pointer._parentOutlet())) { that might be a hack but when the method has this comment it probably cant be worse ;) |
@Adriaaaaan the bug fix should appear in the next point release after a fix lands on master 🚋 🚋 🚋 Until then, please use the previous release you were using. |
Same problem here |
Anyone have a workaround for apps using a pod structure? |
Sorry for the delay here #10822 should fix this. |
Closing in favor of #10822. Let us know if that doesn't resolve the issue for you. |
Thanks! 👍 |
@rwjblue With 1.11.1, I'm still seeing a |
@awaer - Please open another issue to track this (definitely seems like a regression upon initial perusal of the JSBin you provided). |
In Ember 1.12-beta1
{{render 'navigation'}}
won't rendernavigation.hbs
ifnavigation
view is present. If I renamenavigation
view to something else template is being rendered. However I need bothview
andtemplate
. I have more render template + view situations in my app. Is this regression or wanted effect?When views/navigation is present it uses only this file, doesn't care about template(nav tagName is specified in

navigation.coffee
):When there is no view with navigation name(only template rendered):

In Ember.js 1.11-beta5 it works as expected(view combined with template):

In Ember 1.12-beta1 I have to specify
templateName: 'navigation'
in myview/navigation
to make it work as expected.The text was updated successfully, but these errors were encountered: