[fixes #1571] Prevent simulated events from causing nested run-loops.

It turns out, jQuery's simulated events are triggered
synchronously rather then asynchronously. This means,
in some circumstances, when fired they can cause
nested run-loops. This can have some very unexpected
consequences.

@krisselden / @stefanpenner

Author: stefanpenner

packages/ember-views/lib/system/event_dispatcher.js

@@ -152,10 +152,7 @@ Ember.EventDispatcher = Ember.Object.extend(/** @scope Ember.EventDispatcher.pro
         var actionId = Ember.$(evt.currentTarget).attr('data-ember-action'),
             action   = Ember.Handlebars.ActionHelper.registeredActions[actionId];
 
-        // We have to check for action here since in some cases, jQuery will trigger
-        // an event on `removeChild` (i.e. focusout) after we've already torn down the
-        // action handlers for the view.
-        if (action && action.eventName === eventName) {
+        if (action.eventName === eventName) {
           return action.handler(evt);
         }
       }, this);
@@ -192,9 +189,22 @@ Ember.EventDispatcher = Ember.Object.extend(/** @scope Ember.EventDispatcher.pro
   },
 
   _bubbleEvent: function(view, evt, eventName) {
-    return Ember.run(function() {
-      return view.handleEvent(eventName, evt);
-    });
+    if (Ember.run.currentRunLoop){
+      // this works around an issue caused when simulated events
+      // are triggerd. Simulated events occure synchronously rather
+      // then on next tick. This causes an unexpected nested run-loop,
+      // resulting in negative behaviour.
+      //
+      // for reference:
+      // https://github.com/emberjs/ember.js/commit/aafb5eb5693dccf04dd0951385b4c6bb6db7ae46
+      return Ember.run.schedule('actions', function(){
+        return view.handleEvent(eventName, evt);
+      });
+    } else {
+      return Ember.run(function() {
+        return view.handleEvent(eventName, evt);
+      });
+    }
   },
 
   destroy: function() {

packages/ember-views/tests/views/view/destroy_test.js

@@ -20,3 +20,48 @@ test("should teardown viewName on parentView when childView is destroyed", funct
   });
 });
 
+module("Ember.View#destroy - synchronous synthesised event edge-case", {
+  setup: function() {
+    dispatcher = Ember.run(Ember.EventDispatcher, 'create');
+    dispatcher.setup({}, '#qunit-fixture');
+  },
+
+  teardown: function() {
+    Ember.run(dispatcher, 'destroy');
+
+    if (parentView) {
+      Ember.run(parentView, 'destroy');
+    }
+  }
+});
+
+var parentView, dispatcher;
+
+test("focusOut event caused by removal of an in-focus text field should fire on the actions queue", function() {
+  expect(3);
+
+  var focusOutCount = 0;
+
+  parentView = Ember.View.create({
+    focusOut: function(e) {
+      focusOutCount++;
+    },
+    render: function(buffer) {
+      buffer.push("<input>");
+    }
+  });
+
+  Ember.run(parentView, 'appendTo', '#qunit-fixture');
+
+  parentView.$('input').focus();
+
+  Ember.run(function(){
+    parentView.$('input').remove();
+    equal(focusOutCount, 0, 'focusOut was not called yet');
+  });
+
+  equal(focusOutCount, 1, 'focusOut event was fired once, on next tick');
+
+  equal(Ember.$(':focus')[0], undefined, 'nothing is in focus');
+});
+

packages/ember/tests/helpers/link_to_test.js

@@ -332,9 +332,7 @@ test("The {{linkTo}} helper supports bubbles=false", function() {
     router.handleURL("/about");
   });
 
-  Ember.run(function() {
-    Ember.$('#about-contact', '#qunit-fixture').click();
-  });
+  Ember.$('#about-contact', '#qunit-fixture').click();
 
   equal(Ember.$("#contact", "#qunit-fixture").text(), "Contact", "precond - the link worked");