Skip to content

Commit 967ebc1

Browse files
committed
[FIXES #14405] deprecation of enumerable events:
* addEnumerableObserver * removeEnumerableObserver * hasEnumerableObserver
1 parent 77159b1 commit 967ebc1

File tree

1 file changed

+19
-3
lines changed

1 file changed

+19
-3
lines changed

packages/ember-runtime/lib/mixins/enumerable.js

+19-3
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ function iter(key, value) {
9292
@since Ember 0.9
9393
@private
9494
*/
95-
const Enumerable = Mixin.create({
95+
export default Mixin.create({
9696

9797
/**
9898
__Required.__ You must implement this method to apply this mixin.
@@ -872,6 +872,12 @@ const Enumerable = Mixin.create({
872872
@private
873873
*/
874874
addEnumerableObserver(target, opts) {
875+
deprecate(
876+
'Usage of `Enumerable.prototype.addEnumerableObserver` is deprecated.',
877+
false,
878+
{ until: '2.12.0', id: 'ember-metal.enumerable.addEnumerableObserver' }
879+
);
880+
875881
let willChange = (opts && opts.willChange) || 'enumerableWillChange';
876882
let didChange = (opts && opts.didChange) || 'enumerableDidChange';
877883
let hasObservers = get(this, 'hasEnumerableObservers');
@@ -900,6 +906,12 @@ const Enumerable = Mixin.create({
900906
@private
901907
*/
902908
removeEnumerableObserver(target, opts) {
909+
deprecate(
910+
'Usage of `Enumerable.prototype.removeEnumerableObserver is deprecated.',
911+
false,
912+
{ until: '2.12.0', id: 'ember-metal.enumerable.removeEnumerableObserver' }
913+
);
914+
903915
let willChange = (opts && opts.willChange) || 'enumerableWillChange';
904916
let didChange = (opts && opts.didChange) || 'enumerableDidChange';
905917
let hasObservers = get(this, 'hasEnumerableObservers');
@@ -927,6 +939,12 @@ const Enumerable = Mixin.create({
927939
@private
928940
*/
929941
hasEnumerableObservers: computed(function() {
942+
deprecate(
943+
'Usage of `Enumerable.prototype.hasEnumerableObservers` is deprecated.',
944+
false,
945+
{ until: '2.12.0', id: 'ember-metal.enumerable.hasEnumerableObservers' }
946+
);
947+
930948
return hasListeners(this, '@enumerable:change') || hasListeners(this, '@enumerable:before');
931949
}),
932950

@@ -1139,5 +1157,3 @@ const Enumerable = Mixin.create({
11391157
return found;
11401158
}
11411159
});
1142-
1143-
export default Enumerable;

0 commit comments

Comments
 (0)