diff --git a/packages/@ember/string/index.ts b/packages/@ember/string/index.ts index 980b299f16d..d96d1604eae 100644 --- a/packages/@ember/string/index.ts +++ b/packages/@ember/string/index.ts @@ -240,16 +240,14 @@ function deprecateImportFromString( name: string, message = `Importing ${name} from '@ember/string' is deprecated. Please import ${name} from '@ember/template' instead.` ) { - // Disabling this deprecation due to unintended errors in 3.25 - // See https://github.com/emberjs/ember.js/issues/19393 fo more information. - deprecate(message, true, { + deprecate(message, false, { id: 'ember-string.htmlsafe-ishtmlsafe', for: 'ember-source', since: { - available: '3.25', - enabled: '3.25', + available: '4.10', + enabled: '4.10', }, - until: '4.0.0', + until: '5.0.0', url: 'https://deprecations.emberjs.com/v3.x/#toc_ember-string-htmlsafe-ishtmlsafe', }); } diff --git a/packages/ember/index.ts b/packages/ember/index.ts index 479c22d4993..6403995abb5 100644 --- a/packages/ember/index.ts +++ b/packages/ember/index.ts @@ -637,16 +637,14 @@ const deprecateImportFromString = function ( name: string, message = `Importing ${name} from '@ember/string' is deprecated. Please import ${name} from '@ember/template' instead.` ) { - // Disabling this deprecation due to unintended errors in 3.25 - // See https://github.com/emberjs/ember.js/issues/19393 fo more information. - deprecate(message, true, { + deprecate(message, false, { id: 'ember-string.htmlsafe-ishtmlsafe', for: 'ember-source', since: { - available: '3.25', - enabled: '3.25', + available: '4.10', + enabled: '4.10', }, - until: '4.0.0', + until: '5.0.0', url: 'https://deprecations.emberjs.com/v3.x/#toc_ember-string-htmlsafe-ishtmlsafe', }); }; diff --git a/packages/ember/tests/reexports_test.js b/packages/ember/tests/reexports_test.js index e60b94bca7e..f7cf7eb8754 100644 --- a/packages/ember/tests/reexports_test.js +++ b/packages/ember/tests/reexports_test.js @@ -1,5 +1,4 @@ import Ember from '../index'; -import require from 'require'; import { FEATURES } from '@ember/canary-features'; import { AbstractTestCase, confirmExport, moduleFor } from 'internal-test-helpers'; import { DEBUG } from '@glimmer/env'; @@ -20,30 +19,6 @@ moduleFor( }); } - ['@skip Ember.String.htmlSafe exports correctly (but deprecated)'](assert) { - let glimmer = require('@ember/-internals/glimmer'); - expectDeprecation(() => { - assert.equal( - Ember.String.htmlSafe, - glimmer.htmlSafe, - 'Ember.String.htmlSafe is exported correctly' - ); - }, /Importing htmlSafe from '@ember\/string' is deprecated/); - assert.notEqual(glimmer.htmlSafe, undefined, 'Ember.String.htmlSafe is not `undefined`'); - } - - ['@skip Ember.String.isHTMLSafe exports correctly (but deprecated)'](assert) { - let glimmer = require('@ember/-internals/glimmer'); - expectDeprecation(() => { - assert.equal( - Ember.String.isHTMLSafe, - glimmer.isHTMLSafe, - 'Ember.String.isHTMLSafe is exported correctly' - ); - }, /Importing isHTMLSafe from '@ember\/string' is deprecated/); - assert.notEqual(glimmer.isHTMLSafe, undefined, 'Ember.String.isHTMLSafe is not `undefined`'); - } - '@test Ember.FEATURES is exported'(assert) { for (let feature in FEATURES) { assert.equal( @@ -260,8 +235,8 @@ let allExports = [ ['String.classify', '@ember/string', 'classify'], ['String.dasherize', '@ember/string', 'dasherize'], ['String.decamelize', '@ember/string', 'decamelize'], - ['String.htmlSafe', '@ember/-internals/glimmer', 'htmlSafe'], - ['String.isHTMLSafe', '@ember/-internals/glimmer', 'isHTMLSafe'], + ['String.htmlSafe', '@ember/string', 'htmlSafe'], + ['String.isHTMLSafe', '@ember/string', 'isHTMLSafe'], ['String.underscore', '@ember/string', 'underscore'], ['String.w', '@ember/string', 'w'], ['STRINGS', '@ember/string', { get: '_getStrings', set: '_setStrings' }],