-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing error from Model.errors is not autotracked in ember 3.20.5 #7310
Comments
Thanks for the report, can you please make a reproduction PR that we can test against, that would be super helpful |
@igorT the test is in the separate repo https://github.com/andreyfel/ember-data-errors-autotracking-bug. Do you want to have it as a PR for ember-data repository? |
That would be great |
Created PR with reproduction #7313 |
@snewcomer @igorT thank you for this fix! |
@andreyfel I think @snewcomer is planning to |
Originally I've opened the issue within Ember itself emberjs/ember.js#19097, but the fix was done on the ED side #7273.
It seems that the issue wasn't fixed completely as the errors are not re-rendered when I do
model.errors.remove(attr)
.See the integration test in the reproduction repo https://github.com/andreyfel/ember-data-errors-autotracking-bug.
The text was updated successfully, but these errors were encountered: