-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.14.x. links relationships id is reloaded. 2.13.2 is OK. #5143
Comments
Ya it seems quite likely related to (but not 100% sure) #5124, thanks for reporting! |
@stefanpenner, can you modify that twiddle to use that ember-cli-mirage already there with JSONAPI links method? I don't know how... :( |
@johnunclesam I'm not sure I have time this week (currently traveling), if you could give it another try that would be quite helpful. |
I have a fix for #5124, which may cover this issue. I hope to get that released within a day or so. If you could double check that would be great. |
Dear @stefanpenner, I tried install the master branch in my repo. Maybe the problem in #5124 is fixed, but mine is still there unfortunately. I think we should add links example to that twiddle (I wish I could). I enter the post page and if in the .hbs put |
Thanks for testing that out, to bad it wasn't addressed by the above.
Ya, sounds like we will need to investigate. I'll mark this as a bug and hope to get to it soon. |
Try PR #5257 and see if that fixes your links problems |
With 2.13.2 everything ok.
From 2.14.x I have a strange phenomenon:
I'm in the category 1 page, in that page I have a simply
when I go in the post page I have this:
{{#link-to "category" model.category}}Back to category{{/link-to}}
sometimes that link is
/#
.In my router.js I have this:
So after investigating a bit I realized that the blame is of the new "ember-data 2.14.x (and 2.15.x of course, I tried)" and of its bad relationship with the related JSONAPI links (many bugs with JSONAPI related links just fixed in ember-data 2.14.10).
The first time I enter that post page the link "Back to category" is
/#
until it loads (again I can say, because in the category page it already knows aboutpost
and itscategory.id
, isn't it?).I can't reproduce on ember-twiddle because I'm not enough good to. But I realized a twiddle with mirage without links related relationships. Maybe some of you can insert the missing links part in mirage? Here is the link: https://ember-twiddle.com/94b21b033f50339cfa5de0040787f12f
I hope we can fix soon and most important we can understand and test more from this mistake. :)
Maybe related to: #5124, #5062, #4982.
And maybe @mmun (author of bugfix #5119 in 2.14.10) knows something more and better?
The text was updated successfully, but these errors were encountered: