Using filterBy on PromiseManyArray doesn’t work as expected with Glimmer

[jgwhite]

Computed properties that filter a PromiseManyArray don’t re-render as expected when used in templates. See reproduction below:

https://ember-twiddle.com/7e5df2d56a3f78f18e25?numColumns=1&openFiles=application.controller.js%2C

Apologies for the lack of detail — still digging into exactly what’s going wrong here.

[HeroicEric]

I think it has to do with your not updating the other side of the relationship.

If you check out https://ember-twiddle.com/bc20d9b69cf1229b0bc5?numColumns=3&openFiles=application.controller.js%2Capplication.template.hbs%2Capplication.route.js,
the rerender seems to work when the favourites change.

I agree though, that this behavior is confusing. Even more confusing that it seems to work on the initial render...

[sly7-7]

@jgwhite Using the '.content' workaround make the thing working: https://ember-twiddle.com/c0338cd0424f658c60fa?numColumns=3&openFiles=application.controller.js%2Capplication.template.hbs%2Capplication.route.js

[jgwhite]

@sly7-7 thanks, that’s a good tip. Still, it seems like this shouldn’t require any workarounds. ManyArray works just fine.

[sly7-7]

Hmm, alos see, https://ember-twiddle.com/7e5df2d56a3f78f18e25?openFiles=application.controller.js%2Capplication.route.js, using ember 2.0.2, it is working well...

[jgwhite]

@sly7-7 hmm… perhaps a change in the contract for observing enumerables?

[sly7-7]

Yeah, it seems like there is also some issues with ember itself (see the referenced issue), but clearly difficult to find out the root cause

[jgwhite]

This appears to be a problem in computed.filterBy. Closing this issue in favour of emberjs/ember.js#12475

[runspired]

@jgwhite I believe you have closed this prematurely, I still believe this is an ED bug, emberjs/ember.js#12475 (comment)

[jgwhite]

@runspired thanks for investigating further. Re-opening.

[fivetanley]

I don't think replace in ManyArray is following the rules for Ember.Array. It's supposed to set length.

data/addon/-private/system/many-array.js

Line 187 in cf889b3

replace(idx, amt, objects) {

https://github.com/emberjs/ember.js/blob/8d62be51ce9602ce6f3aa05682a2847af8b5dc7a/packages/ember-runtime/lib/mixins/array.js#L95

[fivetanley]

Something else to consider https://github.com/emberjs/ember.js/blob/9899dffe5af3d902a00f9676e7118697d6b1bc7c/packages/ember-runtime/lib/mixins/mutable_array.js#L56

[adam-knights]

@fivetanley would setting length and calling that method be relatively straight forward single line things that ember data should be doing? Could these things be causing emberjs/ember.js#12475 ?

[runspired]

@adam-knights my opinion from the feedback/investigation that I've done is that emberjs/ember.js#12475 is mostly if not entirely related to ED code issues that either originated around the time of Ember 2.0 or were pre-existing issues surfaced by changes in Ember around then.

[Serabe]

Investigating another issue in balinterdi/rarwe-code I see it happens with computed.sort as well.

Twiddle

[sly7-7]

I'm closing, emberjs/ember.js#12908 seems to fix all the things. I just tried the twiddles with ember & ember-data canary, they are working well.

@jgwhite Could you confirm please, and reopen if it does not fix your case ?