Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember Data should use Ember.create in the 1.13 branch #3791

Closed
bmac opened this issue Sep 21, 2015 · 2 comments
Closed

Ember Data should use Ember.create in the 1.13 branch #3791

bmac opened this issue Sep 21, 2015 · 2 comments

Comments

@bmac
Copy link
Member

bmac commented Sep 21, 2015

Pr #3689 ported the EmptyObject work into the 1.13 branch used Object.create. Unfortunately, Object.create is not supported by IE8. We should replace this with Ember.create.

https://github.com/emberjs/data/blob/release-1-13/packages/ember-data/lib/system/empty-object.js#L6
@pangratz pangratz mentioned this issue Oct 7, 2015
Merged
@pangratz
Copy link
Member

pangratz commented Oct 9, 2015

This issue can be closed since #3825 got merged.

@sly7-7
Copy link
Contributor

sly7-7 commented Oct 9, 2015

Thanks :)

@sly7-7 sly7-7 closed this as completed Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmac @pangratz @sly7-7