Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support moduleForAcceptance #60

Closed
dzbo opened this issue Nov 5, 2017 · 6 comments
Closed

Support moduleForAcceptance #60

dzbo opened this issue Nov 5, 2017 · 6 comments

Comments

@dzbo
Copy link

dzbo commented Nov 5, 2017

I see that current support modules are:

const POSSIBLE_MODULES = [
    { expression: { callee: { name: 'module' } } },
    { expression: { callee: { name: 'moduleFor' } } },
    { expression: { callee: { name: 'moduleForComponent' } } },
    { expression: { callee: { name: 'moduleForModel' } } },
  ];

Is there plan to support moduleForAcceptance, so that acceptance tests can also be modified?

@rwjblue
Copy link
Member

rwjblue commented Nov 5, 2017

Yep, I’m working on another RFC to have acceptance tests to run through ember-qunit / ember-test-helpers (current code for acceptance tests is globals based and provided by ember itself).

I’m generally trying to keep this codemod focused on things supported by ember-qunit (which does not include acceptance tests just yet). I’d hate to migrate the current moduleForAcceptance tests to another format before the RFC is proposed with their final setup.

I’ll try to chime in here with a link to the RFC once I have it proposed.

@rwjblue
Copy link
Member

rwjblue commented Nov 6, 2017

Submitted the RFC over here emberjs/rfcs#268

@rwjblue
Copy link
Member

rwjblue commented Nov 17, 2017

RFC is in final comment period. Hopefully we can land it in the next couple of weeks...

@snewcomer
Copy link
Contributor

@rwjblue is the acceptance test api solidified enough to start on the codemod for acceptance tests? Is there anywhere I can help with that?

@xomaczar
Copy link

@rwjblue ^^

@rwjblue
Copy link
Member

rwjblue commented Feb 14, 2018

#73

@rwjblue rwjblue closed this as completed Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants