Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Feature: Optionally don't remove references #32

Open
pzuraq opened this issue Dec 3, 2017 · 1 comment
Open

Possible Feature: Optionally don't remove references #32

pzuraq opened this issue Dec 3, 2017 · 1 comment

Comments

@pzuraq
Copy link
Contributor

pzuraq commented Dec 3, 2017

This just popped up in ember-decorators/argument#43, we have a use case for wanting to be able to just remove the imports, and keep all references.

Basically we have a shim that acts just like the global class Element in the browser (just re-exports it), but exports a shim class to make fastboot work in Node environments. When we strip all the layers of type checking away the browser code should work exactly the same as before, so there is no need to remove the references.

I'm currently adding a plugin to the library itself to do this, I'm not sure it's going to be a very common use case at all so I definitely understand not adding it upstream here, but I thought I'd bring it up.

@pzuraq pzuraq changed the title Possible Feature: Don't remove references Possible Feature: Optionally don't remove references Dec 3, 2017
@layershifter
Copy link
Collaborator

@pzuraq feel free to open PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants