You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently to apply an IP range blacklist in Synapse it is necessary to wrap the the reactor with BlacklistingReactorWrapper and then the agent with BlacklistingAgentWrapper. Ideally all of this logic could be encompassed in a custom BlacklistingHostnameEndpoint which would implement similar logic to HostnameEndpoint, but apply the blacklisting logic to it (the necessary logic is almost identical to what is currently in _IPBlacklistingResolver).
This should allow creating an agent with Agent. usingEndpointFactory.
Some things to note:
This has to fit in somehow with the ProxyAgent (I suspect it should be an either or sort of thing, but not this should be further investigated).
The separation of SimpleHttpClient and MatrixFederationClient makes this a bit more difficult.
There's also some use of the RedirectAgent which may or may not be involved here.
The text was updated successfully, but these errors were encountered:
This issue has been migrated from #8860.
See matrix-org/synapse#8821 (comment) for background on this.
Currently to apply an IP range blacklist in Synapse it is necessary to wrap the the reactor with
BlacklistingReactorWrapper
and then the agent withBlacklistingAgentWrapper
. Ideally all of this logic could be encompassed in a customBlacklistingHostnameEndpoint
which would implement similar logic toHostnameEndpoint
, but apply the blacklisting logic to it (the necessary logic is almost identical to what is currently in_IPBlacklistingResolver
).This should allow creating an agent with
Agent. usingEndpointFactory
.Some things to note:
ProxyAgent
(I suspect it should be an either or sort of thing, but not this should be further investigated).SimpleHttpClient
andMatrixFederationClient
makes this a bit more difficult.RedirectAgent
which may or may not be involved here.The text was updated successfully, but these errors were encountered: