Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel building configuration in CI by installing libatomic1. #18212

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

reivilibre
Copy link
Contributor

Without this, we get the following error when building for 32-bit i686 Linux:

Running before_all...
  
      + /opt/python/cp38-cp38/bin/python -c 'import sys, json, os; json.dump(os.environ.copy(), sys.stdout)'
      + sh -c 'curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain 1.82.0 -y --profile minimal'
  info: downloading installer
  warn: Not enforcing strong cipher suites for TLS, this is potentially less secure
  /tmp/tmp.KlFNNCWiwj/rustup-init: error while loading shared libraries: libatomic.so.1: cannot open shared object file: No such file or directory
                                                              ✕ 1.30s
Error: Command ['sh', '-c', 'curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain 1.82.0 -y --profile minimal'] failed with code 1. 

There may be other platforms where this is relevant, too. (libatomic provides software support for some atomic operations when not supported directly by hardware)

Verified

This commit was signed with the committer’s verified signature.
mp911de Mark Paluch
Newsfile

Verified

This commit was signed with the committer’s verified signature.
mp911de Mark Paluch
Signed-off-by: Olivier 'reivilibre <[email protected]>
@reivilibre reivilibre changed the base branch from develop to release-v1.126 March 4, 2025 16:30
@github-actions github-actions bot deployed to PR Documentation Preview March 4, 2025 16:31 Active
@reivilibre reivilibre marked this pull request as ready for review March 4, 2025 16:44
@reivilibre reivilibre requested a review from a team as a code owner March 4, 2025 16:44
Copy link
Member

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look sane to me.
As long as all containers used to build wheels have libatomic1 available as a library, which I think is true.

@reivilibre reivilibre merged commit b7946c2 into release-v1.126 Mar 4, 2025
38 of 41 checks passed
@reivilibre reivilibre deleted the rei/wheelbuildfix_126 branch March 4, 2025 17:37
reivilibre added a commit that referenced this pull request Mar 5, 2025
Follows: #18212

---------

Signed-off-by: Olivier 'reivilibre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants