Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for overriding id_token_signing_alg_values_supported for an OpenID identity provider #18177

Merged

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Feb 20, 2025

Add support for overriding id_token_signing_alg_values_supported for an OpenID identity provider.

Normally, when discovery is enabled, id_token_signing_alg_values_supported comes from the OpenID Discovery Document (/.well-known/openid-configuration). If nothing was specified, we default to supporting RS256 in the downstream usage.

This PR just adds support for adding a default/overriding the the discovered value just like we do for other things like the token_endpoint, etc.

Todo

  • Maybe add tests

Dev notes

poetry run trial tests.handlers.test_oidc.OidcHandlerTestCase

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

Sorry, something went wrong.

@github-actions github-actions bot deployed to PR Documentation Preview February 20, 2025 03:48 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 20, 2025 03:59 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 20, 2025 04:07 Active
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Tests to make sure that the value is overridden when the config is set, and not overridden when the config isn't set, would be appreciated.

I haven't looked at existing tests, but don't feel the need to build out discovery testing infrastructure for just this PR if it doesn't exist 🙂

@github-actions github-actions bot deployed to PR Documentation Preview February 20, 2025 22:35 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 20, 2025 23:04 Active
@MadLittleMods MadLittleMods marked this pull request as ready for review February 20, 2025 23:55
@MadLittleMods MadLittleMods requested a review from a team as a code owner February 20, 2025 23:55
@MadLittleMods MadLittleMods merged commit caa1f9d into develop Feb 20, 2025
41 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/id_token_signing_alg_values_supported branch February 20, 2025 23:56
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @anoadragon453 🦝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants