Limit size of user directory search queries #18172
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user search has many words we can end up creating really large queries that take a long time for the database to process. Generally, such searches don't return any results anyway (due to limits on user ID and display name length). We "fix" this by cheating and only searching for the first ten words.
MadLittleMods
approved these changes
Feb 17, 2025
Comment on lines
+1243
to
+1246
| # We limit how many terms we include, as otherwise it can use | ||
| # excessive database time if people accidentally search for large | ||
| # strings. | ||
| break |
There was a problem hiding this comment.
10 words definitely seems reasonable as a 10 word display name seems pretty insane at-least for English. For the examples you saw that prompted this work, was it just English copy-pasta mistakes?
And someone can still search for full user ID's as they don't have any spaces.
There was a problem hiding this comment.
I think it was a russian copy-pasta, but yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user search has many words we can end up creating really large queries that take a long time for the database to process. Generally, such searches don't return any results anyway (due to limits on user ID and display name length).
We "fix" this by cheating and only searching for the first ten words.