Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Python 3.8 leftovers #17967

Merged
merged 9 commits into from
Feb 10, 2025
Merged

Cleanup Python 3.8 leftovers #17967

merged 9 commits into from
Feb 10, 2025
+104 −94

Conversation

V02460
Copy link
Contributor

@V02460 V02460 commented Nov 27, 2024

Some small cleanups after Python3.8 became EOL.

  • Move some type imports from typing_extensions to typing
  • Remove the abi3-py38 feature from pyo3

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@V02460 V02460 requested a review from a team as a code owner November 27, 2024 00:18
sandhose
sandhose requested changes Nov 27, 2024
View reviewed changes
@V02460
Copy link
Contributor Author

V02460 commented Dec 6, 2024

I added the abi3-py39 option, so this PR can be merged. Should I find out it is better omitted, I’ll open a new PR.

@V02460 V02460 requested a review from sandhose December 6, 2024 12:42
sandhose
sandhose approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR completely slipped of my queue, sorry about that!

@sandhose sandhose enabled auto-merge (squash) February 10, 2025 16:31
@sandhose sandhose merged commit 068e22b into element-hq:develop Feb 10, 2025
39 checks passed
OlegGirko added a commit to OlegGirko/synapse that referenced this pull request Feb 27, 2025
@OlegGirko
Revert "Cleanup Python 3.8 leftovers (element-hq#17967)"
8822a53 
This breaks Python 3.9 build.

This reverts commit 068e22b.
OlegGirko added a commit to OlegGirko/synapse that referenced this pull request Feb 27, 2025
@OlegGirko
Revert "Cleanup Python 3.8 leftovers (element-hq#17967)"
758426c 
This reverts commit 068e22b.

Reverted commit breaks Synapse on Red Hat Enterprise Linux 9
(Alma Linux 9, Rocky Linux 9. Oracle Linux 9).
Multiple tests fail with TypeError deep inside Pydantic because
issubclass(Literal, Tuple) complains that Literal is not a class.

Reverting the commit mentioned above fixes the issue.

Signed-off-by: Oleg Girko <[email protected]>
OlegGirko added a commit to OlegGirko/synapse that referenced this pull request Feb 27, 2025
@OlegGirko
Revert "Cleanup Python 3.8 leftovers (element-hq#17967)" to fix Synap…
978f5a8 
…se in RHEL9

This reverts commit 068e22b.

Reverted commit breaks Synapse on Red Hat Enterprise Linux 9
(Alma Linux 9, Rocky Linux 9. Oracle Linux 9).
Multiple tests fail with TypeError deep inside Pydantic because
issubclass(Literal, Tuple) complains that Literal is not a class.

Reverting the commit mentioned above fixes the issue.

RHEL9 has Python 3.9.21 and Pydantic 1.10.2.

Signed-off-by: Oleg Girko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston

@sandhose sandhose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@V02460 @sandhose @erikjohnston