Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved communication to recipient that the sender didn't want you to see their message #3831

Closed
turt2live opened this issue May 6, 2017 · 4 comments

Comments

@turt2live
Copy link
Member

turt2live commented May 6, 2017

bounty

Description

Ran into an issue in #megolm where a user turned on the "don't send to unverified devices" box. Because their messages were unable to decrypt, I sent a rageshake. Only after the rageshake was sent was it indicated to me that the user chose to not send keys to me.

With the understanding that it's hard to determine a user having checked that box, it would still be very much appreciated if it was visible in Riot that the message was intentionally blocked from view, instead of appearing as a generic issue.

Suggestions in #megolm to help counteract this also include having an option for the room to disable that setting, for public encrypted rooms like #megolm.

Steps to reproduce

  • Be in an encrypted room with someone
  • Have them turn on "Don't send to unverified devices"
  • Have them double check that your device is not verified
  • Have them send a message to you

I would expect some kind of message along the lines of "This message cannot be decrypted because the user does not trust your device" instead of "The user has not sent us keys for this device" (the generic "It's broken" error).

Log: sent

(although the rageshake sent is probably invalid)

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 58
  • OS: Windows 10
  • URL: riot.im/develop
@uhoreg
Copy link
Member

uhoreg commented May 6, 2017

Suggestions in #megolm to help counteract this also include having an option for the room to disable that setting, for public encrypted rooms like #megolm.

One issue with having a flag like that is that a server admin could impersonate a room admin and set the flag without users realizing it, which could cause them to encrypt to unknown devices without realizing it. So if there is a flag like that, it should only be allowed to be set at room creation time.

@ara4n
Copy link
Member

ara4n commented May 6, 2017

(these made it to rageshake as https://github.com/matrix-org/riot-ios-rageshakes/issues/17 ftr)

@turt2live
Copy link
Member Author

Updated the OP to advertise the bounty :)

@uhoreg
Copy link
Member

uhoreg commented Jan 15, 2020

This is fixed by matrix-org/matrix-js-sdk#1135 (And since I'm on the team, I'm not eligible to collect the bounty.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants