Skip to content

Commit 9cb0069

Browse files
azeierdevelar
authored andcommitted
fix(nsis): make killing the running app silent (#3624)
1 parent fa93671 commit 9cb0069

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/app-builder-lib/templates/nsis/include/allowOnlyOneInstallerInstance.nsh

+2-2
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ Var pid
4848
DetailPrint `Closing running "${PRODUCT_NAME}"...`
4949

5050
# https://github.com/electron-userland/electron-builder/issues/2516#issuecomment-372009092
51-
ExecWait `taskkill /im "${APP_EXECUTABLE_FILENAME}" /fi "PID ne $pid"` $R0
51+
nsExec::Exec `taskkill /im "${APP_EXECUTABLE_FILENAME}" /fi "PID ne $pid"` $R0
5252
# to ensure that files are not "in-use"
5353
Sleep 100
5454

@@ -57,7 +57,7 @@ Var pid
5757
# wait to give a chance to exit gracefully
5858
Sleep 1000
5959
# do not use /t tree kill - app was killed softly already
60-
ExecWait `taskkill /f /im "${APP_EXECUTABLE_FILENAME}" /fi "PID ne $pid"` $R0
60+
nsExec::Exec `taskkill /f /im "${APP_EXECUTABLE_FILENAME}" /fi "PID ne $pid"` $R0
6161
${If} $R0 != 0
6262
DetailPrint `Waiting for "${PRODUCT_NAME}" to close (taskkill exit code $R0).`
6363
Sleep 2000

0 commit comments

Comments
 (0)