Migrate RCTDevSettings to initialize

Summary: Changelog: [Internal]

Reviewed By: fkgozali

Differential Revision: D28595955

fbshipit-source-id: e61c2d321826eafb60fdac820b76d0f7d100796a

Author: RSNara

React/CoreModules/RCTDevSettings.h

@@ -8,6 +8,7 @@
 #import <React/RCTBridge.h>
 #import <React/RCTDefines.h>
 #import <React/RCTEventEmitter.h>
+#import <React/RCTInitializing.h>
 
 @protocol RCTPackagerClientMethod;
 
@@ -40,7 +41,7 @@
 
 @end
 
-@interface RCTDevSettings : RCTEventEmitter
+@interface RCTDevSettings : RCTEventEmitter <RCTInitializing>
 
 - (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource;
 

React/CoreModules/RCTDevSettings.mm

@@ -166,9 +166,22 @@ - (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource
   return self;
 }
 
-- (void)setBundleManager:(RCTBundleManager *)bundleManager
+- (void)initialize
 {
-  _bundleManager = bundleManager;
+#if ENABLE_PACKAGER_CONNECTION
+  if (self.bridge) {
+    RCTBridge *__weak weakBridge = self.bridge;
+    _reloadToken = [[RCTPackagerConnection sharedPackagerConnection]
+        addNotificationHandler:^(id params) {
+          if (params != (id)kCFNull && [params[@"debug"] boolValue]) {
+            weakBridge.executorClass = objc_lookUpClass("RCTWebSocketExecutor");
+          }
+          RCTTriggerReloadCommandListeners(@"Global hotkey");
+        }
+                         queue:dispatch_get_main_queue()
+                     forMethod:@"reload"];
+  }
+#endif
 
 #if RCT_ENABLE_INSPECTOR
   if (self.bridge) {
@@ -178,12 +191,12 @@ - (void)setBundleManager:(RCTBundleManager *)bundleManager
     dispatch_async(dispatch_get_main_queue(), ^{
       [self.bridge
           dispatchBlock:^{
-            [RCTInspectorDevServerHelper connectWithBundleURL:bundleManager.bundleURL];
+            [RCTInspectorDevServerHelper connectWithBundleURL:self.bundleManager.bundleURL];
           }
                   queue:RCTJSThread];
     });
   } else {
-    [RCTInspectorDevServerHelper connectWithBundleURL:bundleManager.bundleURL];
+    [RCTInspectorDevServerHelper connectWithBundleURL:self.bundleManager.bundleURL];
   }
 #endif
 
@@ -192,24 +205,6 @@ - (void)setBundleManager:(RCTBundleManager *)bundleManager
   });
 }
 
-- (void)setBridge:(RCTBridge *)bridge
-{
-  [super setBridge:bridge];
-
-#if ENABLE_PACKAGER_CONNECTION
-  RCTBridge *__weak weakBridge = bridge;
-  _reloadToken = [[RCTPackagerConnection sharedPackagerConnection]
-      addNotificationHandler:^(id params) {
-        if (params != (id)kCFNull && [params[@"debug"] boolValue]) {
-          weakBridge.executorClass = objc_lookUpClass("RCTWebSocketExecutor");
-        }
-        RCTTriggerReloadCommandListeners(@"Global hotkey");
-      }
-                       queue:dispatch_get_main_queue()
-                   forMethod:@"reload"];
-#endif
-}
-
 - (dispatch_queue_t)methodQueue
 {
   return dispatch_get_main_queue();
@@ -512,6 +507,9 @@ - (instancetype)initWithDataSource:(id<RCTDevSettingsDataSource>)dataSource
 {
   return [super init];
 }
+- (void)initialize
+{
+}
 - (BOOL)isHotLoadingAvailable
 {
   return NO;