Skip to content

Commit e02da38

Browse files
authored
Merge pull request #216 from line-o/feat/install-errors
more meaningful installation error messages
2 parents 1428e47 + 13ba419 commit e02da38

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/workflows/semantic-release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
matrix:
1414
os: [ubuntu-latest]
1515
node-version: [14, 16, 18]
16-
exist-version: [latest, release, 5.4.1, 4.10.0]
16+
exist-version: [latest, release, 5.5.1, 4.11.1]
1717
services:
1818
# Label used to access the service container
1919
exist:

index.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -309,12 +309,16 @@ function install (client, options) {
309309

310310
client.app.upload(file.contents, xarName)
311311
.then(response => {
312-
if (!response.success) { return callback(new PluginError('gulp-exist', 'XAR was not uploaded')) }
312+
if (!response.success) {
313+
return callback(new PluginError('gulp-exist', `XAR was not uploaded: ${response.error}`))
314+
}
313315
log(`Install ${xarName}`)
314316
return client.app.install(xarName, customPackageRepoUrl)
315317
})
316318
.then(response => {
317-
if (!response.success) { return callback(new PluginError('gulp-exist', 'XAR Installation failed')) }
319+
if (!response.success) {
320+
return callback(new PluginError('gulp-exist', `XAR Installation failed: ${response.error}`))
321+
}
318322
if (response.result.update) {
319323
log('Application was updated')
320324
return callback(null, response)

0 commit comments

Comments
 (0)