Merge pull request #153 from line-o/fix/ci-setup

fix(ci): improve workflows

Author: line-o

.github/actions/setup-existdb/action.yml

@@ -0,0 +1,21 @@
+name: "Setup eXist-db"
+description: "Start an exist-db instance running in a docker container"
+inputs:
+  docker-tag:
+    description: "Tag of the existdb docker"
+    required: true
+    default: "release"
+
+runs:
+  using: "composite"
+  steps:
+    - id: setup
+      run: |
+        docker pull existdb/existdb:${{ inputs.docker-tag }}
+        docker create --name exist-ci -p 8080:8080 -p 8443:8443 existdb/existdb:${{ inputs.docker-tag }}
+        docker start exist-ci
+      shell: bash
+      # TODO this should rather be polling for a running container / a running service
+    - id: wait-to-exist
+      run: sleep 30
+      shell: bash

.github/workflows/release.yml

@@ -5,34 +5,48 @@ on:
     branches:
       - master
 
+# Tests cannot run on windows due to issues with the windows server 2019 images 
+# the github action runners are using not being able to run linux docker images
+# https://github.com/actions/virtual-environments/issues/1143
+
 jobs:
-  release:
-    name: Release
-    runs-on: ubuntu-latest
+  test:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest]
+        node-version: ['10', '12', '14']
+        docker-tag: [latest, release, 4.7.1]
+
     steps:
-      - uses: actions/checkout@master
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v2
         with:
-          node-version: "14.x"
-
-      - name: npm install and build
-        run:
-          npm ci
-
-      - name: Pull docker image
-        run: docker pull existdb/existdb:release
+          node-version: ${{ matrix.node-version }}
+      - uses: ./.github/actions/setup-existdb
+        with:
+          docker-tag: ${{ matrix.docker-tag }}
 
-      - name: Build docker image
-        run: docker create --name exist-ci -p 8080:8080 -p 8443:8443 existdb/existdb:release
+      - name: Install
+        run: npm ci
 
-      - name: Start docker image
-        run: docker start exist-ci
+      - name: Test
+        run: npm test
 
-      - name: Wait for existdb startup
-        run: sleep 30
+  release:
+    needs: test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v2
+        with:
+          node-version: '14'
 
-      - run: npm test
-      - run: npx semantic-release
+      - name: Release package to npmjs
+        run: |
+          npm ci
+          npx semantic-release
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

.github/workflows/test.yml

@@ -1,47 +1,35 @@
-name: test node-exist
+name: Test Pull Request
 
 on:
   pull_request:
     branches: 
       - master
 
-  push:
-    branches:
-      - master
-
-  workflow_dispatch:
+# Tests cannot run on windows due to issues with the windows server 2019 images 
+# the github action runners are using not being able to run linux docker images
+# https://github.com/actions/virtual-environments/issues/1143
 
 jobs:
-  build:
+  test:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-latest, windows-latest]
-        node-version: [10.x, 12.x, 14.x]
+        os: [ubuntu-latest]
+        node-version: ['10', '12', '14']
         docker-tag: [latest, release, 4.7.1]
 
     steps:
       - uses: actions/checkout@v2
-
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
+      - uses: ./.github/actions/setup-existdb
+        with:
+          docker-tag: ${{ matrix.docker-tag }}
 
-      - name: npm install and build
+      - name: Install
         run: npm ci
 
-      - name: Pull docker image
-        run: docker pull existdb/existdb:${{ matrix.docker-tag }}
-
-      - name: Build docker image
-        run: docker create --name exist-ci -p 8080:8080 -p 8443:8443 existdb/existdb:${{ matrix.docker-tag }}
-
-      - name: Start docker image
-        run: docker start exist-ci
-
-      - name: Wait for existdb startup
-        run: sleep 20
-
-      - name: npm test
-        run: npm test
+      - name: Test
+        run: npm test